Skip to content

Commit 76ff614

Browse files
Yang YingliangMarc Zyngier
authored andcommitted
irqchip/irq-qcom-mpm: fix return value check in qcom_mpm_init()
If devm_platform_ioremap_resource() fails, it never returns NULL, replace NULL check with IS_ERR(). Fixes: a6199bb ("irqchip: Add Qualcomm MPM controller driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Shawn Guo <shawn.guo@linaro.org> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220316025100.1758413-1-yangyingliang@huawei.com
1 parent fa4dcc8 commit 76ff614

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/irqchip/irq-qcom-mpm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ static int qcom_mpm_init(struct device_node *np, struct device_node *parent)
375375
raw_spin_lock_init(&priv->lock);
376376

377377
priv->base = devm_platform_ioremap_resource(pdev, 0);
378-
if (!priv->base)
378+
if (IS_ERR(priv->base))
379379
return PTR_ERR(priv->base);
380380

381381
for (i = 0; i < priv->reg_stride; i++) {

0 commit comments

Comments
 (0)