Skip to content

Commit 76dc162

Browse files
prabhakarladWolfram Sang
authored andcommitted
i2c: riic: Introduce a separate variable for IRQ
Refactor the IRQ handling in riic_i2c_probe by introducing a local variable `irq` to store IRQ numbers instead of assigning them to `ret`. This change improves code readability and clarity. Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
1 parent d621673 commit 76dc162

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

drivers/i2c/busses/i2c-riic.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -464,11 +464,13 @@ static int riic_i2c_probe(struct platform_device *pdev)
464464
return ret;
465465

466466
for (i = 0; i < ARRAY_SIZE(riic_irqs); i++) {
467-
ret = platform_get_irq(pdev, riic_irqs[i].res_num);
468-
if (ret < 0)
469-
return ret;
467+
int irq;
468+
469+
irq = platform_get_irq(pdev, riic_irqs[i].res_num);
470+
if (irq < 0)
471+
return irq;
470472

471-
ret = devm_request_irq(dev, ret, riic_irqs[i].isr,
473+
ret = devm_request_irq(dev, irq, riic_irqs[i].isr,
472474
0, riic_irqs[i].name, riic);
473475
if (ret) {
474476
dev_err(dev, "failed to request irq %s\n", riic_irqs[i].name);

0 commit comments

Comments
 (0)