Skip to content

Commit 753a4d5

Browse files
neocturnedamien-lemoal
authored andcommitted
ata: libata-sata: increase PMP SRST timeout to 10s
On certain SATA controllers, softreset fails after wakeup from S2RAM with the message "softreset failed (1st FIS failed)", sometimes resulting in drives not being detected again. With the increased timeout, this issue is avoided. Instead, "softreset failed (device not ready)" is now logged 1-2 times; this later failure seems to cause fewer problems however, and the drives are detected reliably once they've spun up and the probe is retried. The issue was observed with the primary SATA controller of the QNAP TS-453B, which is an "Intel Corporation Celeron/Pentium Silver Processor SATA Controller [8086:31e3] (rev 06)" integrated in the Celeron J4125 CPU, and the following drives: - Seagate IronWolf ST12000VN0008 - Seagate IronWolf ST8000NE0004 The SATA controller seems to be more relevant to this issue than the drives, as the same drives are always detected reliably on the secondary SATA controller on the same board (an ASMedia 106x) without any "softreset failed" errors even without the increased timeout. Fixes: e7d3ef1 ("libata: change drive ready wait after hard reset to 5s") Cc: stable@vger.kernel.org Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
1 parent 3ef6009 commit 753a4d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/libata.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ enum {
259259
* advised to wait only for the following duration before
260260
* doing SRST.
261261
*/
262-
ATA_TMOUT_PMP_SRST_WAIT = 5000,
262+
ATA_TMOUT_PMP_SRST_WAIT = 10000,
263263

264264
/* When the LPM policy is set to ATA_LPM_MAX_POWER, there might
265265
* be a spurious PHY event, so ignore the first PHY event that

0 commit comments

Comments
 (0)