Skip to content

Commit 7404348

Browse files
arndbPaolo Abeni
authored andcommitted
ipv6: fib: hide unused 'pn' variable
When CONFIG_IPV6_SUBTREES is disabled, the only user is hidden, causing a 'make W=1' warning: net/ipv6/ip6_fib.c: In function 'fib6_add': net/ipv6/ip6_fib.c:1388:32: error: variable 'pn' set but not used [-Werror=unused-but-set-variable] Add another #ifdef around the variable declaration, matching the other uses in this file. Fixes: 66729e1 ("[IPV6] ROUTE: Make sure we have fn->leaf when adding a node on subtree.") Link: https://lore.kernel.org/netdev/20240322131746.904943-1-arnd@kernel.org/ Reviewed-by: David Ahern <dsahern@kernel.org> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Eric Dumazet <edumazet@google.com> Link: https://lore.kernel.org/r/20240408074219.3030256-1-arnd@kernel.org Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent faf2300 commit 7404348

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

net/ipv6/ip6_fib.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,7 +1385,10 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,
13851385
struct nl_info *info, struct netlink_ext_ack *extack)
13861386
{
13871387
struct fib6_table *table = rt->fib6_table;
1388-
struct fib6_node *fn, *pn = NULL;
1388+
struct fib6_node *fn;
1389+
#ifdef CONFIG_IPV6_SUBTREES
1390+
struct fib6_node *pn = NULL;
1391+
#endif
13891392
int err = -ENOMEM;
13901393
int allow_create = 1;
13911394
int replace_required = 0;
@@ -1409,9 +1412,9 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,
14091412
goto out;
14101413
}
14111414

1415+
#ifdef CONFIG_IPV6_SUBTREES
14121416
pn = fn;
14131417

1414-
#ifdef CONFIG_IPV6_SUBTREES
14151418
if (rt->fib6_src.plen) {
14161419
struct fib6_node *sn;
14171420

0 commit comments

Comments
 (0)