Skip to content

Commit 73b5ab2

Browse files
Hsiao Chien SungChun-Kuang Hu
authored andcommitted
drm/mediatek: Fix underrun in VDO1 when switches off the layer
Do not reset Merge while using CMDQ because reset API doesn't wait for frame done event as CMDQ does and could lead to underrun when the layer is switching off. Fixes: aaf94f7 ("drm/mediatek: Add display merge async reset control") Reviewed-by: CK Hu <ck.hu@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> Link: https://patchwork.kernel.org/project/dri-devel/patch/20231214055847.4936-23-shawn.sung@mediatek.com/ Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
1 parent 8ac6935 commit 73b5ab2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/mediatek/mtk_disp_merge.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ void mtk_merge_stop_cmdq(struct device *dev, struct cmdq_pkt *cmdq_pkt)
103103
mtk_ddp_write(cmdq_pkt, 0, &priv->cmdq_reg, priv->regs,
104104
DISP_REG_MERGE_CTRL);
105105

106-
if (priv->async_clk)
106+
if (!cmdq_pkt && priv->async_clk)
107107
reset_control_reset(priv->reset_ctl);
108108
}
109109

0 commit comments

Comments
 (0)