Skip to content

Commit 734387e

Browse files
Hao JiaPeter Zijlstra
authored andcommitted
sched/deadline: Remove superfluous rq clock update in push_dl_task()
The change to call update_rq_clock() before activate_task() commit 840d719 ("sched/deadline: Update rq_clock of later_rq when pushing a task") is no longer needed since commit f490481 ("sched/deadline: Fix double accounting of rq/running bw in push & pull") removed the add_running_bw() before the activate_task(). So we remove some comments that are no longer needed and update rq clock in activate_task(). Signed-off-by: Hao Jia <jiahao.os@bytedance.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com> Link: https://lore.kernel.org/r/20220430085843.62939-3-jiahao.os@bytedance.com
1 parent 2679a83 commit 734387e

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

kernel/sched/deadline.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2318,13 +2318,7 @@ static int push_dl_task(struct rq *rq)
23182318

23192319
deactivate_task(rq, next_task, 0);
23202320
set_task_cpu(next_task, later_rq->cpu);
2321-
2322-
/*
2323-
* Update the later_rq clock here, because the clock is used
2324-
* by the cpufreq_update_util() inside __add_running_bw().
2325-
*/
2326-
update_rq_clock(later_rq);
2327-
activate_task(later_rq, next_task, ENQUEUE_NOCLOCK);
2321+
activate_task(later_rq, next_task, 0);
23282322
ret = 1;
23292323

23302324
resched_curr(later_rq);

0 commit comments

Comments
 (0)