Skip to content

Commit 732f35c

Browse files
Jim Lingregkh
authored andcommitted
usb: host: tegra: Prevent host controller crash when OTG port is used
When a USB device is connected to the OTG port, the tegra_xhci_id_work() routine transitions the PHY to host mode and calls xhci_hub_control() with the SetPortFeature command to enable port power. In certain cases, the XHCI controller may be in a low-power state when this operation occurs. If xhci_hub_control() is invoked while the controller is suspended, the PORTSC register may return 0xFFFFFFFF, indicating a read failure. This causes xhci_hc_died() to be triggered, leading to host controller shutdown. Example backtrace: [ 105.445736] Workqueue: events tegra_xhci_id_work [ 105.445747] dump_backtrace+0x0/0x1e8 [ 105.445759] xhci_hc_died.part.48+0x40/0x270 [ 105.445769] tegra_xhci_set_port_power+0xc0/0x240 [ 105.445774] tegra_xhci_id_work+0x130/0x240 To prevent this, ensure the controller is fully resumed before interacting with hardware registers by calling pm_runtime_get_sync() prior to the host mode transition and xhci_hub_control(). Fixes: f836e78 ("usb: xhci-tegra: Add OTG support") Cc: stable <stable@kernel.org> Signed-off-by: Jim Lin <jilin@nvidia.com> Signed-off-by: Wayne Chang <waynec@nvidia.com> Link: https://lore.kernel.org/r/20250422114001.126367-1-waynec@nvidia.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 241e2ce commit 732f35c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/usb/host/xhci-tegra.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,6 +1364,7 @@ static void tegra_xhci_id_work(struct work_struct *work)
13641364
tegra->otg_usb3_port = tegra_xusb_padctl_get_usb3_companion(tegra->padctl,
13651365
tegra->otg_usb2_port);
13661366

1367+
pm_runtime_get_sync(tegra->dev);
13671368
if (tegra->host_mode) {
13681369
/* switch to host mode */
13691370
if (tegra->otg_usb3_port >= 0) {
@@ -1393,13 +1394,15 @@ static void tegra_xhci_id_work(struct work_struct *work)
13931394
}
13941395

13951396
tegra_xhci_set_port_power(tegra, true, true);
1397+
pm_runtime_mark_last_busy(tegra->dev);
13961398

13971399
} else {
13981400
if (tegra->otg_usb3_port >= 0)
13991401
tegra_xhci_set_port_power(tegra, false, false);
14001402

14011403
tegra_xhci_set_port_power(tegra, true, false);
14021404
}
1405+
pm_runtime_put_autosuspend(tegra->dev);
14031406
}
14041407

14051408
#if IS_ENABLED(CONFIG_PM) || IS_ENABLED(CONFIG_PM_SLEEP)

0 commit comments

Comments
 (0)