Skip to content

Commit 71349cc

Browse files
William DeanMarc Zyngier
authored andcommitted
irqchip/mips-gic: Check the return value of ioremap() in gic_of_init()
The function ioremap() in gic_of_init() can fail, so its return value should be checked. Reported-by: Hacash Robot <hacashRobot@santino.com> Signed-off-by: William Dean <williamsukatube@163.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220723100128.2964304-1-williamsukatube@163.com
1 parent c904cda commit 71349cc

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/irqchip/irq-mips-gic.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -734,6 +734,10 @@ static int __init gic_of_init(struct device_node *node,
734734
}
735735

736736
mips_gic_base = ioremap(gic_base, gic_len);
737+
if (!mips_gic_base) {
738+
pr_err("Failed to ioremap gic_base\n");
739+
return -ENOMEM;
740+
}
737741

738742
gicconfig = read_gic_config();
739743
gic_shared_intrs = FIELD_GET(GIC_CONFIG_NUMINTERRUPTS, gicconfig);

0 commit comments

Comments
 (0)