Skip to content

Commit 6fc058a

Browse files
dillon-minbebarino
authored andcommitted
clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after system enter shell
stm32's clk driver register two ltdc gate clk to clk core by clk_hw_register_gate() and clk_hw_register_composite() first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use. second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver both of them point to the same offset of stm32's RCC register. after kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]' is no one to use. but, actually 'stm32f429_aux_clk[]' is in use. stm32f469/746/769 have the same issue, fix it. Fixes: daf2d11 ("clk: stm32f4: Add lcd-tft clock") Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-send-email-dillon.minfei@gmail.com/ Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDUjqFFwkOeQeFDg@mail.gmail.com/ Signed-off-by: Dillon Min <dillon.minfei@gmail.com> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Acked-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com> Acked-by: Stephen Boyd <sboyd@kernel.org> Link: https://lore.kernel.org/r/1635232282-3992-10-git-send-email-dillon.minfei@gmail.com Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent fa55b7d commit 6fc058a

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/clk/clk-stm32f4.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ static const struct stm32f4_gate_data stm32f429_gates[] __initconst = {
129129
{ STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" },
130130
{ STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" },
131131
{ STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" },
132-
{ STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
133132
};
134133

135134
static const struct stm32f4_gate_data stm32f469_gates[] __initconst = {
@@ -211,7 +210,6 @@ static const struct stm32f4_gate_data stm32f469_gates[] __initconst = {
211210
{ STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" },
212211
{ STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" },
213212
{ STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" },
214-
{ STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
215213
};
216214

217215
static const struct stm32f4_gate_data stm32f746_gates[] __initconst = {
@@ -286,7 +284,6 @@ static const struct stm32f4_gate_data stm32f746_gates[] __initconst = {
286284
{ STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" },
287285
{ STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" },
288286
{ STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" },
289-
{ STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
290287
};
291288

292289
static const struct stm32f4_gate_data stm32f769_gates[] __initconst = {
@@ -364,7 +361,6 @@ static const struct stm32f4_gate_data stm32f769_gates[] __initconst = {
364361
{ STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" },
365362
{ STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" },
366363
{ STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" },
367-
{ STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
368364
{ STM32F4_RCC_APB2ENR, 30, "mdio", "apb2_div" },
369365
};
370366

0 commit comments

Comments
 (0)