Skip to content

Commit 6f6583e

Browse files
Muhammad Ahmedalexdeucher
authored andcommitted
drm/amd/display: Fix MST recognizes connected displays as one
[What] MST now recognizes both connected displays Fixes: 927e784 ("drm/amd/display: Add symclk enable/disable during stream enable/disable") Reviewed-by: Charlene Liu <charlene.liu@amd.com> Acked-by: Stylon Wang <stylon.wang@amd.com> Signed-off-by: Muhammad Ahmed <ahmed.ahmed@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent ce9ecca commit 6f6583e

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1178,12 +1178,15 @@ void dce110_disable_stream(struct pipe_ctx *pipe_ctx)
11781178
dto_params.otg_inst = tg->inst;
11791179
dto_params.timing = &pipe_ctx->stream->timing;
11801180
dp_hpo_inst = pipe_ctx->stream_res.hpo_dp_stream_enc->inst;
1181-
dccg->funcs->set_dtbclk_dto(dccg, &dto_params);
1182-
dccg->funcs->disable_symclk32_se(dccg, dp_hpo_inst);
1183-
dccg->funcs->set_dpstreamclk(dccg, REFCLK, tg->inst, dp_hpo_inst);
1184-
} else if (pipe_ctx->stream->signal == SIGNAL_TYPE_DISPLAY_PORT_MST && dccg->funcs->disable_symclk_se)
1181+
if (dccg) {
1182+
dccg->funcs->set_dtbclk_dto(dccg, &dto_params);
1183+
dccg->funcs->disable_symclk32_se(dccg, dp_hpo_inst);
1184+
dccg->funcs->set_dpstreamclk(dccg, REFCLK, tg->inst, dp_hpo_inst);
1185+
}
1186+
} else if (dccg && dccg->funcs->disable_symclk_se) {
11851187
dccg->funcs->disable_symclk_se(dccg, stream_enc->stream_enc_inst,
11861188
link_enc->transmitter - TRANSMITTER_UNIPHY_A);
1189+
}
11871190

11881191
if (dc->link_srv->dp_is_128b_132b_signal(pipe_ctx)) {
11891192
/* TODO: This looks like a bug to me as we are disabling HPO IO when
@@ -2658,11 +2661,11 @@ void dce110_prepare_bandwidth(
26582661
struct clk_mgr *dccg = dc->clk_mgr;
26592662

26602663
dce110_set_safe_displaymarks(&context->res_ctx, dc->res_pool);
2661-
2662-
dccg->funcs->update_clocks(
2663-
dccg,
2664-
context,
2665-
false);
2664+
if (dccg)
2665+
dccg->funcs->update_clocks(
2666+
dccg,
2667+
context,
2668+
false);
26662669
}
26672670

26682671
void dce110_optimize_bandwidth(
@@ -2673,10 +2676,11 @@ void dce110_optimize_bandwidth(
26732676

26742677
dce110_set_displaymarks(dc, context);
26752678

2676-
dccg->funcs->update_clocks(
2677-
dccg,
2678-
context,
2679-
true);
2679+
if (dccg)
2680+
dccg->funcs->update_clocks(
2681+
dccg,
2682+
context,
2683+
true);
26802684
}
26812685

26822686
static void dce110_program_front_end_for_pipe(

drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2692,8 +2692,6 @@ void dcn20_enable_stream(struct pipe_ctx *pipe_ctx)
26922692
struct dce_hwseq *hws = dc->hwseq;
26932693
unsigned int k1_div = PIXEL_RATE_DIV_NA;
26942694
unsigned int k2_div = PIXEL_RATE_DIV_NA;
2695-
struct link_encoder *link_enc = link_enc_cfg_get_link_enc(pipe_ctx->stream->link);
2696-
struct stream_encoder *stream_enc = pipe_ctx->stream_res.stream_enc;
26972695

26982696
if (dc->link_srv->dp_is_128b_132b_signal(pipe_ctx)) {
26992697
if (dc->hwseq->funcs.setup_hpo_hw_control)
@@ -2713,10 +2711,8 @@ void dcn20_enable_stream(struct pipe_ctx *pipe_ctx)
27132711
dto_params.timing = &pipe_ctx->stream->timing;
27142712
dto_params.ref_dtbclk_khz = dc->clk_mgr->funcs->get_dtb_ref_clk_frequency(dc->clk_mgr);
27152713
dccg->funcs->set_dtbclk_dto(dccg, &dto_params);
2716-
} else if (pipe_ctx->stream->signal == SIGNAL_TYPE_DISPLAY_PORT_MST && dccg->funcs->enable_symclk_se)
2717-
dccg->funcs->enable_symclk_se(dccg,
2718-
stream_enc->stream_enc_inst, link_enc->transmitter - TRANSMITTER_UNIPHY_A);
2719-
2714+
} else {
2715+
}
27202716
if (hws->funcs.calculate_dccg_k1_k2_values && dc->res_pool->dccg->funcs->set_pixel_rate_div) {
27212717
hws->funcs.calculate_dccg_k1_k2_values(pipe_ctx, &k1_div, &k2_div);
27222718

drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ void mpc32_power_on_blnd_lut(
7575
if (power_on) {
7676
REG_UPDATE(MPCC_MCM_MEM_PWR_CTRL[mpcc_id], MPCC_MCM_1DLUT_MEM_PWR_FORCE, 0);
7777
REG_WAIT(MPCC_MCM_MEM_PWR_CTRL[mpcc_id], MPCC_MCM_1DLUT_MEM_PWR_STATE, 0, 1, 5);
78-
} else {
78+
} else if (!mpc->ctx->dc->debug.disable_mem_low_power) {
7979
ASSERT(false);
8080
/* TODO: change to mpc
8181
* dpp_base->ctx->dc->optimized_required = true;

0 commit comments

Comments
 (0)