Skip to content

Commit 6f65540

Browse files
Chia-Wei Wangcminyard
authored andcommitted
ipmi: kcs: aspeed: Update port address comments
Remove AST_usrGuide_KCS.pdf as it is no longer maintained. Add more descriptions as the driver now supports the I/O address configurations for both the KCS Data and Cmd/Status interface registers. Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com> Message-Id: <20220920020333.601-1-chiawei_wang@aspeedtech.com> [I don't like removing documentation, but the document in question was a personal note by an employee and nothing official and not necessarily guaranteed to be accurate in the future. So go ahead and remove it.] Signed-off-by: Corey Minyard <cminyard@mvista.com>
1 parent ec7174f commit 6f65540

File tree

1 file changed

+18
-11
lines changed

1 file changed

+18
-11
lines changed

drivers/char/ipmi/kcs_bmc_aspeed.c

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -207,17 +207,24 @@ static void aspeed_kcs_updateb(struct kcs_bmc_device *kcs_bmc, u32 reg, u8 mask,
207207
}
208208

209209
/*
210-
* AST_usrGuide_KCS.pdf
211-
* 2. Background:
212-
* we note D for Data, and C for Cmd/Status, default rules are
213-
* A. KCS1 / KCS2 ( D / C:X / X+4 )
214-
* D / C : CA0h / CA4h
215-
* D / C : CA8h / CACh
216-
* B. KCS3 ( D / C:XX2h / XX3h )
217-
* D / C : CA2h / CA3h
218-
* D / C : CB2h / CB3h
219-
* C. KCS4
220-
* D / C : CA4h / CA5h
210+
* We note D for Data, and C for Cmd/Status, default rules are
211+
*
212+
* 1. Only the D address is given:
213+
* A. KCS1/KCS2 (D/C: X/X+4)
214+
* D/C: CA0h/CA4h
215+
* D/C: CA8h/CACh
216+
* B. KCS3 (D/C: XX2/XX3h)
217+
* D/C: CA2h/CA3h
218+
* C. KCS4 (D/C: X/X+1)
219+
* D/C: CA4h/CA5h
220+
*
221+
* 2. Both the D/C addresses are given:
222+
* A. KCS1/KCS2/KCS4 (D/C: X/Y)
223+
* D/C: CA0h/CA1h
224+
* D/C: CA8h/CA9h
225+
* D/C: CA4h/CA5h
226+
* B. KCS3 (D/C: XX2/XX3h)
227+
* D/C: CA2h/CA3h
221228
*/
222229
static int aspeed_kcs_set_address(struct kcs_bmc_device *kcs_bmc, u32 addrs[2], int nr_addrs)
223230
{

0 commit comments

Comments
 (0)