Skip to content

Commit 6f411fb

Browse files
Sebastian Andrzej SiewiorPaolo Abeni
authored andcommitted
net: ena: Flush XDP packets on error.
xdp_do_flush() should be invoked before leaving the NAPI poll function after a XDP-redirect. This is not the case if the driver leaves via the error path (after having a redirect in one of its previous iterations). Invoke xdp_do_flush() also in the error path. Cc: Arthur Kiyanovski <akiyano@amazon.com> Cc: David Arinzon <darinzon@amazon.com> Cc: Noam Dagan <ndagan@amazon.com> Cc: Saeed Bishara <saeedb@amazon.com> Cc: Shay Agroskin <shayagr@amazon.com> Fixes: a318c70 ("net: ena: introduce XDP redirect implementation") Acked-by: Arthur Kiyanovski <akiyano@amazon.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Jesper Dangaard Brouer <hawk@kernel.org> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 4a0f07d commit 6f411fb

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/net/ethernet/amazon/ena/ena_netdev.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1833,6 +1833,9 @@ static int ena_clean_rx_irq(struct ena_ring *rx_ring, struct napi_struct *napi,
18331833
return work_done;
18341834

18351835
error:
1836+
if (xdp_flags & ENA_XDP_REDIRECT)
1837+
xdp_do_flush();
1838+
18361839
adapter = netdev_priv(rx_ring->netdev);
18371840

18381841
if (rc == -ENOSPC) {

0 commit comments

Comments
 (0)