Skip to content

Commit 6f18d7a

Browse files
srishanmalexdeucher
authored andcommitted
drm/amdgpu: Fix missing parameter descriptions in ih_v7_0.c
Rectifies kdoc warnings related to the 'ih' parameter in the 'ih_v7_0_get_wptr', 'ih_v7_0_irq_rearm', and 'ih_v7_0_set_rptr' functions within the 'ih_v7_0.c' file. Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:392: warning: Function parameter or member 'ih' not described in 'ih_v7_0_get_wptr' drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:432: warning: Function parameter or member 'ih' not described in 'ih_v7_0_irq_rearm' drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:458: warning: Function parameter or member 'ih' not described in 'ih_v7_0_set_rptr' Fixes: 12443fc ("drm/amdgpu: Add ih v7_0 ip block support") Cc: Likun Gao <Likun.Gao@amd.com> Cc: Hawking Zhang <Hawking.Zhang@amd.com> Cc: Christian König <christian.koenig@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent a02cfac commit 6f18d7a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/gpu/drm/amd/amdgpu/ih_v7_0.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -378,9 +378,10 @@ static void ih_v7_0_irq_disable(struct amdgpu_device *adev)
378378
}
379379

380380
/**
381-
* ih_v7_0_get_wptr - get the IH ring buffer wptr
381+
* ih_v7_0_get_wptr() - get the IH ring buffer wptr
382382
*
383383
* @adev: amdgpu_device pointer
384+
* @ih: IH ring buffer to fetch wptr
384385
*
385386
* Get the IH ring buffer wptr from either the register
386387
* or the writeback memory buffer. Also check for
@@ -425,6 +426,7 @@ static u32 ih_v7_0_get_wptr(struct amdgpu_device *adev,
425426
* ih_v7_0_irq_rearm - rearm IRQ if lost
426427
*
427428
* @adev: amdgpu_device pointer
429+
* @ih: IH ring to match
428430
*
429431
*/
430432
static void ih_v7_0_irq_rearm(struct amdgpu_device *adev,
@@ -450,8 +452,7 @@ static void ih_v7_0_irq_rearm(struct amdgpu_device *adev,
450452
* ih_v7_0_set_rptr - set the IH ring buffer rptr
451453
*
452454
* @adev: amdgpu_device pointer
453-
*
454-
* Set the IH ring buffer rptr.
455+
* @ih: IH ring buffer to set rptr
455456
*/
456457
static void ih_v7_0_set_rptr(struct amdgpu_device *adev,
457458
struct amdgpu_ih_ring *ih)

0 commit comments

Comments
 (0)