Skip to content

Commit 6ed0dc3

Browse files
leo-sunli1alexdeucher
authored andcommitted
drm/amd/display: Default IPS to RCG_IN_ACTIVE_IPS2_IN_OFF
[Why] Recent findings show negligible power savings between IPS2 and RCG during static desktop. In fact, DCN related clocks are higher when IPS2 is enabled vs RCG. RCG_IN_ACTIVE is also the default policy for another OS supported by DC, and it has faster entry/exit. [How] Remove previous logic that checked for IPS2 support, and just default to `DMUB_IPS_RCG_IN_ACTIVE_IPS2_IN_OFF`. Fixes: 199888a ("drm/amd/display: Update IPS default mode for DCN35/DCN351") Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by: Leo Li <sunpeng.li@amd.com> Signed-off-by: Zaeem Mohamed <zaeem.mohamed@amd.com> Tested-by: Mark Broadworth <mark.broadworth@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit 8f772d7) Cc: stable@vger.kernel.org
1 parent d59bddc commit 6ed0dc3

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1920,26 +1920,6 @@ static enum dmub_ips_disable_type dm_get_default_ips_mode(
19201920
switch (amdgpu_ip_version(adev, DCE_HWIP, 0)) {
19211921
case IP_VERSION(3, 5, 0):
19221922
case IP_VERSION(3, 6, 0):
1923-
/*
1924-
* On DCN35 systems with Z8 enabled, it's possible for IPS2 + Z8 to
1925-
* cause a hard hang. A fix exists for newer PMFW.
1926-
*
1927-
* As a workaround, for non-fixed PMFW, force IPS1+RCG as the deepest
1928-
* IPS state in all cases, except for s0ix and all displays off (DPMS),
1929-
* where IPS2 is allowed.
1930-
*
1931-
* When checking pmfw version, use the major and minor only.
1932-
*/
1933-
if ((adev->pm.fw_version & 0x00FFFF00) < 0x005D6300)
1934-
ret = DMUB_IPS_RCG_IN_ACTIVE_IPS2_IN_OFF;
1935-
else if (amdgpu_ip_version(adev, GC_HWIP, 0) > IP_VERSION(11, 5, 0))
1936-
/*
1937-
* Other ASICs with DCN35 that have residency issues with
1938-
* IPS2 in idle.
1939-
* We want them to use IPS2 only in display off cases.
1940-
*/
1941-
ret = DMUB_IPS_RCG_IN_ACTIVE_IPS2_IN_OFF;
1942-
break;
19431923
case IP_VERSION(3, 5, 1):
19441924
ret = DMUB_IPS_RCG_IN_ACTIVE_IPS2_IN_OFF;
19451925
break;

0 commit comments

Comments
 (0)