Skip to content

Commit 6cef7da

Browse files
ahunter6acmel
authored andcommitted
perf intel-pt: Fix system_wide dummy event for hybrid
User space tasks can migrate between CPUs, so when tracing selected CPUs, system-wide sideband is still needed, however evlist->core.has_user_cpus is not set in the hybrid case, so check the target cpu_list instead. Fixes: 7d189ca ("perf intel-pt: Track sideband system-wide when needed") Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20221012082259.22394-3-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 5a3d470 commit 6cef7da

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/perf/arch/x86/util/intel-pt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,7 +866,7 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,
866866
* User space tasks can migrate between CPUs, so when tracing
867867
* selected CPUs, sideband for all CPUs is still needed.
868868
*/
869-
need_system_wide_tracking = evlist->core.has_user_cpus &&
869+
need_system_wide_tracking = opts->target.cpu_list &&
870870
!intel_pt_evsel->core.attr.exclude_user;
871871

872872
tracking_evsel = evlist__add_aux_dummy(evlist, need_system_wide_tracking);

0 commit comments

Comments
 (0)