Skip to content

Commit 6b0de7d

Browse files
committed
Merge tag 'nvme-5.19-2022-07-07' of git://git.infradead.org/nvme into block-5.19
Pull NVMe fixes from Christoph: "nvme fixes for Linux 5.19 - another bogus identifier quirk (Keith Busch) - use struct group in the tracer to avoid a gcc warning (Keith Busch)" * tag 'nvme-5.19-2022-07-07' of git://git.infradead.org/nvme: nvme: use struct group for generic command dwords nvme-pci: phison e16 has bogus namespace ids
2 parents f3163d8 + 5c629dc commit 6b0de7d

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

drivers/nvme/host/pci.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3465,7 +3465,8 @@ static const struct pci_device_id nvme_id_table[] = {
34653465
{ PCI_DEVICE(0x1987, 0x5012), /* Phison E12 */
34663466
.driver_data = NVME_QUIRK_BOGUS_NID, },
34673467
{ PCI_DEVICE(0x1987, 0x5016), /* Phison E16 */
3468-
.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
3468+
.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN |
3469+
NVME_QUIRK_BOGUS_NID, },
34693470
{ PCI_DEVICE(0x1b4b, 0x1092), /* Lexar 256 GB SSD */
34703471
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST |
34713472
NVME_QUIRK_IGNORE_DEV_SUBNQN, },

drivers/nvme/host/trace.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ TRACE_EVENT(nvme_setup_cmd,
6969
__entry->metadata = !!blk_integrity_rq(req);
7070
__entry->fctype = cmd->fabrics.fctype;
7171
__assign_disk_name(__entry->disk, req->q->disk);
72-
memcpy(__entry->cdw10, &cmd->common.cdw10,
72+
memcpy(__entry->cdw10, &cmd->common.cdws,
7373
sizeof(__entry->cdw10));
7474
),
7575
TP_printk("nvme%d: %sqid=%d, cmdid=%u, nsid=%u, flags=0x%x, meta=0x%x, cmd=(%s %s)",

include/linux/nvme.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -906,12 +906,14 @@ struct nvme_common_command {
906906
__le32 cdw2[2];
907907
__le64 metadata;
908908
union nvme_data_ptr dptr;
909+
struct_group(cdws,
909910
__le32 cdw10;
910911
__le32 cdw11;
911912
__le32 cdw12;
912913
__le32 cdw13;
913914
__le32 cdw14;
914915
__le32 cdw15;
916+
);
915917
};
916918

917919
struct nvme_rw_command {

0 commit comments

Comments
 (0)