Skip to content

Commit 697624e

Browse files
aford173storulf
authored andcommitted
pmdomain: imx8mp-blk-ctrl: imx8mp_blk: Add fdcc clock to hdmimix domain
According to i.MX8MP RM and HDMI ADD, the fdcc clock is part of hdmi rx verification IP that should not enable for HDMI TX. But actually if the clock is disabled before HDMI/LCDIF probe, LCDIF will not get pixel clock from HDMI PHY and print the error logs: [CRTC:39:crtc-2] vblank wait timed out WARNING: CPU: 2 PID: 9 at drivers/gpu/drm/drm_atomic_helper.c:1634 drm_atomic_helper_wait_for_vblanks.part.0+0x23c/0x260 Add fdcc clock to LCDIF and HDMI TX power domains to fix the issue. Signed-off-by: Adam Ford <aford173@gmail.com> Reviewed-by: Jacky Bai <ping.bai@nxp.com> Signed-off-by: Sandor Yu <Sandor.yu@nxp.com> Link: https://lore.kernel.org/r/20240203165307.7806-5-aford173@gmail.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent a0691f2 commit 697624e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/pmdomain/imx/imx8mp-blk-ctrl.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ struct imx8mp_blk_ctrl_domain_data {
5555
const char *gpc_name;
5656
};
5757

58-
#define DOMAIN_MAX_CLKS 2
58+
#define DOMAIN_MAX_CLKS 3
5959
#define DOMAIN_MAX_PATHS 3
6060

6161
struct imx8mp_blk_ctrl_domain {
@@ -457,8 +457,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = {
457457
},
458458
[IMX8MP_HDMIBLK_PD_LCDIF] = {
459459
.name = "hdmiblk-lcdif",
460-
.clk_names = (const char *[]){ "axi", "apb" },
461-
.num_clks = 2,
460+
.clk_names = (const char *[]){ "axi", "apb", "fdcc" },
461+
.num_clks = 3,
462462
.gpc_name = "lcdif",
463463
.path_names = (const char *[]){"lcdif-hdmi"},
464464
.num_paths = 1,
@@ -483,8 +483,8 @@ static const struct imx8mp_blk_ctrl_domain_data imx8mp_hdmi_domain_data[] = {
483483
},
484484
[IMX8MP_HDMIBLK_PD_HDMI_TX] = {
485485
.name = "hdmiblk-hdmi-tx",
486-
.clk_names = (const char *[]){ "apb", "ref_266m" },
487-
.num_clks = 2,
486+
.clk_names = (const char *[]){ "apb", "ref_266m", "fdcc" },
487+
.num_clks = 3,
488488
.gpc_name = "hdmi-tx",
489489
},
490490
[IMX8MP_HDMIBLK_PD_HDMI_TX_PHY] = {

0 commit comments

Comments
 (0)