Skip to content

Commit 6955bfe

Browse files
namjaejeonSteve French
authored andcommitted
ksmbd: use ib_device_get_netdev() instead of calling ops.get_netdev
ULPs are not supposed to call to ops.* directly. Suggested-by: Leon Romanovsky <leon@kernel.org> Reviewed-by: Leon Romanovsky <leon@kernel.org> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 6171063 commit 6955bfe

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

fs/smb/server/transport_rdma.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2142,8 +2142,7 @@ static int smb_direct_ib_client_add(struct ib_device *ib_dev)
21422142
if (ib_dev->node_type != RDMA_NODE_IB_CA)
21432143
smb_direct_port = SMB_DIRECT_PORT_IWARP;
21442144

2145-
if (!ib_dev->ops.get_netdev ||
2146-
!rdma_frwr_is_supported(&ib_dev->attrs))
2145+
if (!rdma_frwr_is_supported(&ib_dev->attrs))
21472146
return 0;
21482147

21492148
smb_dev = kzalloc(sizeof(*smb_dev), KSMBD_DEFAULT_GFP);
@@ -2243,8 +2242,7 @@ bool ksmbd_rdma_capable_netdev(struct net_device *netdev)
22432242
for (i = 0; i < smb_dev->ib_dev->phys_port_cnt; i++) {
22442243
struct net_device *ndev;
22452244

2246-
ndev = smb_dev->ib_dev->ops.get_netdev(smb_dev->ib_dev,
2247-
i + 1);
2245+
ndev = ib_device_get_netdev(smb_dev->ib_dev, i + 1);
22482246
if (!ndev)
22492247
continue;
22502248

0 commit comments

Comments
 (0)