Skip to content

Commit 68ca249

Browse files
namhyungacmel
authored andcommitted
perf test shell stat_bpf_counters: Fix test on Intel
As of now, bpf counters (bperf) don't support event groups. But the default perf stat includes topdown metrics if supported (on recent Intel machines) which require groups. That makes perf stat exiting. $ sudo perf stat --bpf-counter true bpf managed perf events do not yet support groups. Actually the test explicitly uses cycles event only, but it missed to pass the option when it checks the availability of the command. Fixes: 2c0cb9f ("perf test: Add a shell test for 'perf stat --bpf-counters' new option") Reviewed-by: Song Liu <song@kernel.org> Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: bpf@vger.kernel.org Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20230825164152.165610-2-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 11f5710 commit 68ca249

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/perf/tests/shell/stat_bpf_counters.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ compare_number()
2222
}
2323

2424
# skip if --bpf-counters is not supported
25-
if ! perf stat --bpf-counters true > /dev/null 2>&1; then
25+
if ! perf stat -e cycles --bpf-counters true > /dev/null 2>&1; then
2626
if [ "$1" = "-v" ]; then
2727
echo "Skipping: --bpf-counters not supported"
28-
perf --no-pager stat --bpf-counters true || true
28+
perf --no-pager stat -e cycles --bpf-counters true || true
2929
fi
3030
exit 2
3131
fi

0 commit comments

Comments
 (0)