drm/imagination: only init job done fences once

brendan-king · MTCoster · commit 68c3de7f707e · 2025-03-03T12:10:13.000Z
Ensure job done fences are only initialised once. This fixes a memory manager not clean warning from drm_mm_takedown on module unload. Cc: stable@vger.kernel.org Fixes: eaf01ee ("drm/imagination: Implement job submission and scheduling") Signed-off-by: Brendan King <brendan.king@imgtec.com> Reviewed-by: Matt Coster <matt.coster@imgtec.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250226-init-done-fences-once-v2-1-c1b2f556b329@imgtec.com Signed-off-by: Matt Coster <matt.coster@imgtec.com>
diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imagination/pvr_queue.c
@@ -313,8 +313,9 @@ pvr_queue_cccb_fence_init(struct dma_fence *fence, struct pvr_queue *queue)
 static void
 pvr_queue_job_fence_init(struct dma_fence *fence, struct pvr_queue *queue)
 {
-	pvr_queue_fence_init(fence, queue, &pvr_queue_job_fence_ops,
-			     &queue->job_fence_ctx);
+	if (!fence->ops)
+		pvr_queue_fence_init(fence, queue, &pvr_queue_job_fence_ops,
+				     &queue->job_fence_ctx);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -313,8 +313,9 @@ pvr_queue_cccb_fence_init(struct dma_fence fence, struct pvr_queue queue)`
`313`	`313`	`static void`
`314`	`314`	`pvr_queue_job_fence_init(struct dma_fence fence, struct pvr_queue queue)`
`315`	`315`	`{`
`316`		`- pvr_queue_fence_init(fence, queue, &pvr_queue_job_fence_ops,`
`317`		`- &queue->job_fence_ctx);`
	`316`	`+ if (!fence->ops)`
	`317`	`+ pvr_queue_fence_init(fence, queue, &pvr_queue_job_fence_ops,`
	`318`	`+ &queue->job_fence_ctx);`
`318`	`319`	`}`
`319`	`320`
`320`	`321`	`/**`