Skip to content

Commit 66dd346

Browse files
author
Christoph Hellwig
committed
nvme-pci: disable namespace identifiers for Qemu controllers
Qemu unconditionally reports a UUID, which depending on the qemu version is either all-null (which is incorrect but harmless) or contains a single bit set for all controllers. In addition it can also optionally report a eui64 which needs to be manually set. Disable namespace identifiers for Qemu controlles entirely even if in some cases they could be set correctly through manual intervention. Reported-by: Luis Chamberlain <mcgrof@kernel.org> Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Keith Busch <kbusch@kernel.org> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
1 parent a98a945 commit 66dd346

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/nvme/host/pci.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3409,7 +3409,10 @@ static const struct pci_device_id nvme_id_table[] = {
34093409
.driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
34103410
{ PCI_VDEVICE(INTEL, 0x5845), /* Qemu emulated controller */
34113411
.driver_data = NVME_QUIRK_IDENTIFY_CNS |
3412-
NVME_QUIRK_DISABLE_WRITE_ZEROES, },
3412+
NVME_QUIRK_DISABLE_WRITE_ZEROES |
3413+
NVME_QUIRK_BOGUS_NID, },
3414+
{ PCI_VDEVICE(REDHAT, 0x0010), /* Qemu emulated controller */
3415+
.driver_data = NVME_QUIRK_BOGUS_NID, },
34133416
{ PCI_DEVICE(0x126f, 0x2263), /* Silicon Motion unidentified */
34143417
.driver_data = NVME_QUIRK_NO_NS_DESC_LIST, },
34153418
{ PCI_DEVICE(0x1bb1, 0x0100), /* Seagate Nytro Flash Storage */

0 commit comments

Comments
 (0)