Skip to content

Commit 663a877

Browse files
Xiang Liualexdeucher
authored andcommitted
drm/amdgpu: Check aca enabled inside cper init/fini func
Move code about checking aca enabled to the cper init/fini function to make code clean. Signed-off-by: Xiang Liu <xiang.liu@amd.com> Reviewed-by: Tao Zhou <tao.zhou1@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 30eb41f commit 663a877

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_cper.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -538,6 +538,9 @@ static int amdgpu_cper_ring_init(struct amdgpu_device *adev)
538538

539539
int amdgpu_cper_init(struct amdgpu_device *adev)
540540
{
541+
if (!amdgpu_aca_is_enabled(adev))
542+
return 0;
543+
541544
mutex_init(&adev->cper.cper_lock);
542545

543546
adev->cper.enabled = true;
@@ -548,6 +551,9 @@ int amdgpu_cper_init(struct amdgpu_device *adev)
548551

549552
int amdgpu_cper_fini(struct amdgpu_device *adev)
550553
{
554+
if (!amdgpu_aca_is_enabled(adev))
555+
return 0;
556+
551557
adev->cper.enabled = false;
552558

553559
amdgpu_ring_fini(&(adev->cper.ring_buf));

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3091,8 +3091,7 @@ static int amdgpu_device_ip_init(struct amdgpu_device *adev)
30913091

30923092
amdgpu_fru_get_product_info(adev);
30933093

3094-
if (amdgpu_aca_is_enabled(adev))
3095-
r = amdgpu_cper_init(adev);
3094+
r = amdgpu_cper_init(adev);
30963095

30973096
init_failed:
30983097

@@ -3454,8 +3453,7 @@ static int amdgpu_device_ip_fini(struct amdgpu_device *adev)
34543453
{
34553454
int i, r;
34563455

3457-
if (amdgpu_aca_is_enabled(adev))
3458-
amdgpu_cper_fini(adev);
3456+
amdgpu_cper_fini(adev);
34593457

34603458
if (amdgpu_sriov_vf(adev) && adev->virt.ras_init_done)
34613459
amdgpu_virt_release_ras_err_handler_data(adev);

0 commit comments

Comments
 (0)