Skip to content

Commit 6469b2f

Browse files
committed
ARM: dts: ti: omap: Fix bandgap thermal cells addressing for omap3/4
Fix "thermal_sys: cpu_thermal: Failed to read thermal-sensors cells: -2" error on boot for omap3/4. This is caused by wrong addressing in the dts for bandgap sensor for single sensor instances. Note that omap4-cpu-thermal.dtsi is shared across omap4/5 and dra7, so we can't just change the addressing in omap4-cpu-thermal.dtsi. Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Cc: Carl Philipp Klemm <philipp@uvos.xyz> Cc: Merlijn Wajer <merlijn@wizzup.org> Cc: Pavel Machek <pavel@ucw.cz> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Fixes: a761d51 ("ARM: dts: omap3: Add cpu_thermal zone") Fixes: 0bbf6c5 ("arm: dts: add omap4 CPU thermal data") Signed-off-by: Tony Lindgren <tony@atomide.com>
1 parent 0bb80ec commit 6469b2f

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

arch/arm/boot/dts/ti/omap/omap3-cpu-thermal.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ cpu_thermal: cpu-thermal {
1212
polling-delay = <1000>; /* milliseconds */
1313
coefficients = <0 20000>;
1414

15-
/* sensor ID */
16-
thermal-sensors = <&bandgap 0>;
15+
thermal-sensors = <&bandgap>;
1716

1817
cpu_trips: trips {
1918
cpu_alert0: cpu_alert {

arch/arm/boot/dts/ti/omap/omap4-cpu-thermal.dtsi

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@ cpu_thermal: cpu_thermal {
1212
polling-delay-passive = <250>; /* milliseconds */
1313
polling-delay = <1000>; /* milliseconds */
1414

15-
/* sensor ID */
15+
/*
16+
* See 44xx files for single sensor addressing, omap5 and dra7 need
17+
* also sensor ID for addressing.
18+
*/
1619
thermal-sensors = <&bandgap 0>;
1720

1821
cpu_trips: trips {

arch/arm/boot/dts/ti/omap/omap443x.dtsi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
};
7070

7171
&cpu_thermal {
72+
thermal-sensors = <&bandgap>;
7273
coefficients = <0 20000>;
7374
};
7475

arch/arm/boot/dts/ti/omap/omap4460.dtsi

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
};
8080

8181
&cpu_thermal {
82+
thermal-sensors = <&bandgap>;
8283
coefficients = <348 (-9301)>;
8384
};
8485

0 commit comments

Comments
 (0)