Skip to content

Commit 642d6a2

Browse files
pmachatakuba-moo
authored andcommitted
mlxsw: reg: Drop unnecessary writes from mlxsw_reg_sfmr_pack()
The MLXSW_REG_ZERO at the beginning of the function wipes the whole payload. There's no need to set vtfp and vv to false explicitly. Signed-off-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Amit Cohen <amcohen@nvidia.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Link: https://lore.kernel.org/r/04a51ea7cf31eea0ef7707311d8e864e2d9ef307.1700503644.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 7eb9029 commit 642d6a2

File tree

1 file changed

+0
-2
lines changed
  • drivers/net/ethernet/mellanox/mlxsw

1 file changed

+0
-2
lines changed

drivers/net/ethernet/mellanox/mlxsw/reg.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1973,8 +1973,6 @@ static inline void mlxsw_reg_sfmr_pack(char *payload,
19731973
mlxsw_reg_sfmr_op_set(payload, op);
19741974
mlxsw_reg_sfmr_fid_set(payload, fid);
19751975
mlxsw_reg_sfmr_fid_offset_set(payload, fid_offset);
1976-
mlxsw_reg_sfmr_vtfp_set(payload, false);
1977-
mlxsw_reg_sfmr_vv_set(payload, false);
19781976
mlxsw_reg_sfmr_flood_rsp_set(payload, flood_rsp);
19791977
mlxsw_reg_sfmr_flood_bridge_type_set(payload, bridge_type);
19801978
mlxsw_reg_sfmr_smpe_valid_set(payload, smpe_valid);

0 commit comments

Comments
 (0)