Skip to content

Commit 63f4dbb

Browse files
lategoodbyegregkh
authored andcommitted
staging: vchiq_arm: Register debugfs after cdev
The commit 2a4d15a ("staging: vchiq: Refactor vchiq cdev code") moved the debugfs directory creation before vchiq character device registration. In case the latter fails, the debugfs directory won't be cleaned up. Fixes: 2a4d15a ("staging: vchiq: Refactor vchiq cdev code") Signed-off-by: Stefan Wahren <wahrenst@gmx.net> Link: https://lore.kernel.org/r/20250309125014.37166-2-wahrenst@gmx.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 96622d5 commit 63f4dbb

File tree

1 file changed

+2
-2
lines changed
  • drivers/staging/vc04_services/interface/vchiq_arm

1 file changed

+2
-2
lines changed

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1386,8 +1386,6 @@ static int vchiq_probe(struct platform_device *pdev)
13861386
return ret;
13871387
}
13881388

1389-
vchiq_debugfs_init(&mgmt->state);
1390-
13911389
dev_dbg(&pdev->dev, "arm: platform initialised - version %d (min %d)\n",
13921390
VCHIQ_VERSION, VCHIQ_VERSION_MIN);
13931391

@@ -1401,6 +1399,8 @@ static int vchiq_probe(struct platform_device *pdev)
14011399
return ret;
14021400
}
14031401

1402+
vchiq_debugfs_init(&mgmt->state);
1403+
14041404
bcm2835_audio = vchiq_device_register(&pdev->dev, "bcm2835-audio");
14051405
bcm2835_camera = vchiq_device_register(&pdev->dev, "bcm2835-camera");
14061406

0 commit comments

Comments
 (0)