Skip to content

Commit 63e2019

Browse files
liuhangbindavem330
authored andcommitted
selftests: pmtu.sh: fix result checking
In the PMTU test, when all previous tests are skipped and the new test passes, the exit code is set to 0. However, the current check mistakenly treats this as an assignment, causing the check to pass every time. Consequently, regardless of how many tests have failed, if the latest test passes, the PMTU test will report a pass. Fixes: 2a9d371 ("selftests: pmtu.sh: improve the test result processing") Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent db456d9 commit 63e2019

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/testing/selftests/net/pmtu.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2048,7 +2048,7 @@ run_test() {
20482048
case $ret in
20492049
0)
20502050
all_skipped=false
2051-
[ $exitcode=$ksft_skip ] && exitcode=0
2051+
[ $exitcode -eq $ksft_skip ] && exitcode=0
20522052
;;
20532053
$ksft_skip)
20542054
[ $all_skipped = true ] && exitcode=$ksft_skip

0 commit comments

Comments
 (0)