Skip to content

Commit 62a5df4

Browse files
mantas-pvinodkoul
authored andcommitted
phy: qcom-qmp-usb: fix serdes init sequence for IPQ6018
Commit 23fd679 ("phy: qcom-qmp: add USB3 PHY support for IPQ6018") noted that IPQ6018 init is identical to IPQ8074. Yet downstream uses separate serdes init sequence for IPQ6018. Since already existing IPQ9574 serdes init sequence is identical, just reuse it and fix failing USB3 mode in IPQ6018. Fixes: 23fd679 ("phy: qcom-qmp: add USB3 PHY support for IPQ6018") Signed-off-by: Mantas Pucka <mantas@8devices.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/1706026160-17520-3-git-send-email-mantas@8devices.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent f74c35b commit 62a5df4

File tree

1 file changed

+19
-1
lines changed

1 file changed

+19
-1
lines changed

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1621,6 +1621,24 @@ static const struct qmp_usb_offsets qmp_usb_offsets_v7 = {
16211621
.rx = 0x1000,
16221622
};
16231623

1624+
static const struct qmp_phy_cfg ipq6018_usb3phy_cfg = {
1625+
.lanes = 1,
1626+
1627+
.offsets = &qmp_usb_offsets_ipq8074,
1628+
1629+
.serdes_tbl = ipq9574_usb3_serdes_tbl,
1630+
.serdes_tbl_num = ARRAY_SIZE(ipq9574_usb3_serdes_tbl),
1631+
.tx_tbl = msm8996_usb3_tx_tbl,
1632+
.tx_tbl_num = ARRAY_SIZE(msm8996_usb3_tx_tbl),
1633+
.rx_tbl = ipq8074_usb3_rx_tbl,
1634+
.rx_tbl_num = ARRAY_SIZE(ipq8074_usb3_rx_tbl),
1635+
.pcs_tbl = ipq8074_usb3_pcs_tbl,
1636+
.pcs_tbl_num = ARRAY_SIZE(ipq8074_usb3_pcs_tbl),
1637+
.vreg_list = qmp_phy_vreg_l,
1638+
.num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
1639+
.regs = qmp_v3_usb3phy_regs_layout,
1640+
};
1641+
16241642
static const struct qmp_phy_cfg ipq8074_usb3phy_cfg = {
16251643
.lanes = 1,
16261644

@@ -2571,7 +2589,7 @@ static int qmp_usb_probe(struct platform_device *pdev)
25712589
static const struct of_device_id qmp_usb_of_match_table[] = {
25722590
{
25732591
.compatible = "qcom,ipq6018-qmp-usb3-phy",
2574-
.data = &ipq8074_usb3phy_cfg,
2592+
.data = &ipq6018_usb3phy_cfg,
25752593
}, {
25762594
.compatible = "qcom,ipq8074-qmp-usb3-phy",
25772595
.data = &ipq8074_usb3phy_cfg,

0 commit comments

Comments
 (0)