Skip to content

Commit 61f162a

Browse files
John Garrymartinkpetersen
authored andcommitted
scsi: pm8001: Fix use-after-free for aborted TMF sas_task
Currently a use-after-free may occur if a TMF sas_task is aborted before we handle the IO completion in mpi_ssp_completion(). The abort occurs due to timeout. When the timeout occurs, the SAS_TASK_STATE_ABORTED flag is set and the sas_task is freed in pm8001_exec_internal_tmf_task(). However, if the I/O completion occurs later, the I/O completion still thinks that the sas_task is available. Fix this by clearing the ccb->task if the TMF times out - the I/O completion handler does nothing if this pointer is cleared. Link: https://lore.kernel.org/r/1643289172-165636-3-git-send-email-john.garry@huawei.com Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Acked-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: John Garry <john.garry@huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 0aed75f commit 61f162a

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/scsi/pm8001/pm8001_sas.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -769,8 +769,13 @@ static int pm8001_exec_internal_tmf_task(struct domain_device *dev,
769769
res = -TMF_RESP_FUNC_FAILED;
770770
/* Even TMF timed out, return direct. */
771771
if (task->task_state_flags & SAS_TASK_STATE_ABORTED) {
772+
struct pm8001_ccb_info *ccb = task->lldd_task;
773+
772774
pm8001_dbg(pm8001_ha, FAIL, "TMF task[%x]timeout.\n",
773775
tmf->tmf);
776+
777+
if (ccb)
778+
ccb->task = NULL;
774779
goto ex_err;
775780
}
776781

0 commit comments

Comments
 (0)