Skip to content

Commit 60c828c

Browse files
committed
Merge tag 'for-linus-hexagon-6.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/bcain/linux
Pull hexagon updates from Brian Cain: - Move kernel prototypes out of uapi header to internal header - Fix to address an unbalanced spinlock - Miscellaneous patches to fix static checks - Update bcain@quicinc.com->brian.cain@oss.qualcomm.com * tag 'for-linus-hexagon-6.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/bcain/linux: MAINTAINERS: Update my email address hexagon: Fix unbalanced spinlock in die() hexagon: Fix warning comparing pointer to 0 hexagon: Move kernel prototypes out of uapi/asm/setup.h header hexagon: time: Remove redundant null check for resource hexagon: fix using plain integer as NULL pointer warning in cmpxchg
2 parents 04a3389 + 84d7821 commit 60c828c

File tree

7 files changed

+31
-18
lines changed

7 files changed

+31
-18
lines changed

.mailmap

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,8 @@ Boris Brezillon <bbrezillon@kernel.org> <boris.brezillon@bootlin.com>
142142
Boris Brezillon <bbrezillon@kernel.org> <boris.brezillon@free-electrons.com>
143143
Brendan Higgins <brendan.higgins@linux.dev> <brendanhiggins@google.com>
144144
Brian Avery <b.avery@hp.com>
145+
Brian Cain <bcain@kernel.org> <brian.cain@oss.qualcomm.com>
146+
Brian Cain <bcain@kernel.org> <bcain@quicinc.com>
145147
Brian King <brking@us.ibm.com>
146148
Brian Silverman <bsilver16384@gmail.com> <brian.silverman@bluerivertech.com>
147149
Bryan Tan <bryan-bt.tan@broadcom.com> <bryantan@vmware.com>

MAINTAINERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19453,7 +19453,7 @@ F: drivers/misc/fastrpc.c
1945319453
F: include/uapi/misc/fastrpc.h
1945419454

1945519455
QUALCOMM HEXAGON ARCHITECTURE
19456-
M: Brian Cain <bcain@quicinc.com>
19456+
M: Brian Cain <brian.cain@oss.qualcomm.com>
1945719457
L: linux-hexagon@vger.kernel.org
1945819458
S: Supported
1945919459
T: git git://git.kernel.org/pub/scm/linux/kernel/git/bcain/linux.git

arch/hexagon/include/asm/cmpxchg.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ __arch_xchg(unsigned long x, volatile void *ptr, int size)
5656
__typeof__(ptr) __ptr = (ptr); \
5757
__typeof__(*(ptr)) __old = (old); \
5858
__typeof__(*(ptr)) __new = (new); \
59-
__typeof__(*(ptr)) __oldval = 0; \
59+
__typeof__(*(ptr)) __oldval = (__typeof__(*(ptr))) 0; \
6060
\
6161
asm volatile( \
6262
"1: %0 = memw_locked(%1);\n" \

arch/hexagon/include/asm/setup.h

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/* SPDX-License-Identifier: GPL-2.0-only */
2+
/*
3+
* Copyright (c) 2010-2011, The Linux Foundation. All rights reserved.
4+
*
5+
* This program is free software; you can redistribute it and/or modify
6+
* it under the terms of the GNU General Public License version 2 and
7+
* only version 2 as published by the Free Software Foundation.
8+
*/
9+
10+
#ifndef _ASM_HEXAGON_SETUP_H
11+
#define _ASM_HEXAGON_SETUP_H
12+
13+
#include <linux/init.h>
14+
#include <uapi/asm/setup.h>
15+
16+
extern char external_cmdline_buffer;
17+
18+
void __init setup_arch_memory(void);
19+
20+
#endif

arch/hexagon/include/uapi/asm/setup.h

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,9 @@
1717
* 02110-1301, USA.
1818
*/
1919

20-
#ifndef _ASM_SETUP_H
21-
#define _ASM_SETUP_H
22-
23-
#ifdef __KERNEL__
24-
#include <linux/init.h>
25-
#else
26-
#define __init
27-
#endif
20+
#ifndef _UAPI_ASM_HEXAGON_SETUP_H
21+
#define _UAPI_ASM_HEXAGON_SETUP_H
2822

2923
#include <asm-generic/setup.h>
3024

31-
extern char external_cmdline_buffer;
32-
33-
void __init setup_arch_memory(void);
34-
3525
#endif

arch/hexagon/kernel/time.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,7 @@ static void __init time_init_deferred(void)
170170

171171
ce_dev->cpumask = cpu_all_mask;
172172

173-
if (!resource)
174-
resource = rtos_timer_device.resource;
173+
resource = rtos_timer_device.resource;
175174

176175
/* ioremap here means this has to run later, after paging init */
177176
rtos_timer = ioremap(resource->start, resource_size(resource));

arch/hexagon/kernel/traps.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task, unsigned long *fp,
135135
}
136136

137137
/* Attempt to continue past exception. */
138-
if (0 == newfp) {
138+
if (!newfp) {
139139
struct pt_regs *regs = (struct pt_regs *) (((void *)fp)
140140
+ 8);
141141

@@ -195,8 +195,10 @@ int die(const char *str, struct pt_regs *regs, long err)
195195
printk(KERN_EMERG "Oops: %s[#%d]:\n", str, ++die.counter);
196196

197197
if (notify_die(DIE_OOPS, str, regs, err, pt_cause(regs), SIGSEGV) ==
198-
NOTIFY_STOP)
198+
NOTIFY_STOP) {
199+
spin_unlock_irq(&die.lock);
199200
return 1;
201+
}
200202

201203
print_modules();
202204
show_regs(regs);

0 commit comments

Comments
 (0)