Skip to content

Commit 6032f58

Browse files
shavitmichaelwilldeacon
authored andcommitted
iommu/arm-smmu-v3: Update comment about STE liveness
Update the comment to reflect the fact that the STE is not always installed. arm_smmu_domain_finalise_s1 intentionnaly calls arm_smmu_write_ctx_desc while the STE is not installed. Reviewed-by: Nicolin Chen <nicolinc@nvidia.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Michael Shavit <mshavit@google.com> Tested-by: Nicolin Chen <nicolinc@nvidia.com> Link: https://lore.kernel.org/r/20230915211705.v8.8.I7a8beb615e2520ad395d96df94b9ab9708ee0d9c@changeid Signed-off-by: Will Deacon <will@kernel.org>
1 parent 5e14313 commit 6032f58

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1091,7 +1091,7 @@ int arm_smmu_write_ctx_desc(struct arm_smmu_master *master, int ssid,
10911091
cdptr[3] = cpu_to_le64(cd->mair);
10921092

10931093
/*
1094-
* STE is live, and the SMMU might read dwords of this CD in any
1094+
* STE may be live, and the SMMU might read dwords of this CD in any
10951095
* order. Ensure that it observes valid values before reading
10961096
* V=1.
10971097
*/

0 commit comments

Comments
 (0)