Skip to content

Commit 600dbaf

Browse files
committed
modpost: convert do_pnp_device_entry() to a generic handler
do_pnp_device_entry() no longer needs to iterate over the pnp_device_id array. Convert it to a generic ->do_entry() handler. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
1 parent a5d8d41 commit 600dbaf

File tree

1 file changed

+9
-21
lines changed

1 file changed

+9
-21
lines changed

scripts/mod/file2alias.c

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -627,27 +627,16 @@ static void do_acpi_entry(struct module *mod, void *symval)
627627
}
628628

629629
/* looks like: "pnp:dD" */
630-
static void do_pnp_device_entry(void *symval, unsigned long size,
631-
struct module *mod)
630+
static void do_pnp_device_entry(struct module *mod, void *symval)
632631
{
633-
const unsigned long id_size = SIZE_pnp_device_id;
634-
const unsigned int count = (size / id_size)-1;
635-
unsigned int i;
636-
637-
device_id_check(mod->name, "pnp", size, id_size, symval);
638-
639-
for (i = 0; i < count; i++) {
640-
DEF_FIELD_ADDR(symval + i*id_size, pnp_device_id, id);
641-
char acpi_id[sizeof(*id)];
642-
int j;
643-
644-
module_alias_printf(mod, false, "pnp:d%s*", *id);
632+
DEF_FIELD_ADDR(symval, pnp_device_id, id);
633+
char acpi_id[sizeof(*id)];
645634

646-
/* fix broken pnp bus lowercasing */
647-
for (j = 0; j < sizeof(acpi_id); j++)
648-
acpi_id[j] = toupper((*id)[j]);
649-
module_alias_printf(mod, false, "acpi*:%s:*", acpi_id);
650-
}
635+
/* fix broken pnp bus lowercasing */
636+
for (unsigned int i = 0; i < sizeof(acpi_id); i++)
637+
acpi_id[i] = toupper((*id)[i]);
638+
module_alias_printf(mod, false, "pnp:d%s*", *id);
639+
module_alias_printf(mod, false, "acpi*:%s:*", acpi_id);
651640
}
652641

653642
/* looks like: "pnp:dD" for every device of the card */
@@ -1531,6 +1520,7 @@ static const struct devtable devtable[] = {
15311520
{"cdx", SIZE_cdx_device_id, do_cdx_entry},
15321521
{"vchiq", SIZE_vchiq_device_id, do_vchiq_entry},
15331522
{"coreboot", SIZE_coreboot_device_id, do_coreboot_entry},
1523+
{"pnp", SIZE_pnp_device_id, do_pnp_device_entry},
15341524
{"pnp_card", SIZE_pnp_card_device_id, do_pnp_card_entry},
15351525
};
15361526

@@ -1580,8 +1570,6 @@ void handle_moddevtable(struct module *mod, struct elf_info *info,
15801570
do_usb_table(symval, sym->st_size, mod);
15811571
else if (sym_is(name, namelen, "of"))
15821572
do_of_table(symval, sym->st_size, mod);
1583-
else if (sym_is(name, namelen, "pnp"))
1584-
do_pnp_device_entry(symval, sym->st_size, mod);
15851573
else {
15861574
int i;
15871575

0 commit comments

Comments
 (0)