Skip to content

Commit 5e63970

Browse files
johnharr-intellucasdemarchi
authored andcommitted
drm/xe/guc: Fix capture of steering registers
The list of registers to capture on a GPU hang includes some that require steering. Unfortunately, the flag to say this was being wiped to due a missing OR on the assignment of the next flag field. Fix that. Fixes: b170d69 ("drm/xe/guc: Add XE_LP steered register lists") Cc: Zhanjun Dong <zhanjun.dong@intel.com> Cc: Alan Previn <alan.previn.teres.alexis@intel.com> Cc: Matt Roper <matthew.d.roper@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: intel-xe@lists.freedesktop.org Signed-off-by: John Harrison <John.C.Harrison@Intel.com> Reviewed-by: Matt Roper <matthew.d.roper@intel.com> Reviewed-by: Zhanjun Dong <zhanjun.dong@intel.com> Link: https://lore.kernel.org/r/20250417195215.3002210-2-John.C.Harrison@Intel.com (cherry picked from commit 532da44) Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
1 parent c1c9cad commit 5e63970

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/xe/xe_guc_capture.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ static void __fill_ext_reg(struct __guc_mmio_reg_descr *ext,
359359

360360
ext->reg = XE_REG(extlist->reg.__reg.addr);
361361
ext->flags = FIELD_PREP(GUC_REGSET_STEERING_NEEDED, 1);
362-
ext->flags = FIELD_PREP(GUC_REGSET_STEERING_GROUP, slice_id);
362+
ext->flags |= FIELD_PREP(GUC_REGSET_STEERING_GROUP, slice_id);
363363
ext->flags |= FIELD_PREP(GUC_REGSET_STEERING_INSTANCE, subslice_id);
364364
ext->regname = extlist->name;
365365
}

0 commit comments

Comments
 (0)