Skip to content

Commit 5def5c1

Browse files
khayash1storulf
authored andcommitted
mmc: sdhci-f-sdh30: Replace with sdhci_pltfm
Even if sdhci_pltfm_pmops is specified for PM, this driver doesn't apply sdhci_pltfm, so the structure is not correctly referenced in PM functions. This applies sdhci_pltfm to this driver to fix this issue. - Call sdhci_pltfm_init() instead of sdhci_alloc_host() and other functions that covered by sdhci_pltfm. - Move ops and quirks to sdhci_pltfm_data - Replace sdhci_priv() with own private function sdhci_f_sdh30_priv(). Fixes: 87a5074 ("mmc: sdhci: host: add new f_sdh30") Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20230630004533.26644-1-hayashi.kunihiko@socionext.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent d442632 commit 5def5c1

File tree

1 file changed

+27
-33
lines changed

1 file changed

+27
-33
lines changed

drivers/mmc/host/sdhci_f_sdh30.c

Lines changed: 27 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,16 @@ struct f_sdhost_priv {
2929
bool enable_cmd_dat_delay;
3030
};
3131

32+
static void *sdhci_f_sdhost_priv(struct sdhci_host *host)
33+
{
34+
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
35+
36+
return sdhci_pltfm_priv(pltfm_host);
37+
}
38+
3239
static void sdhci_f_sdh30_soft_voltage_switch(struct sdhci_host *host)
3340
{
34-
struct f_sdhost_priv *priv = sdhci_priv(host);
41+
struct f_sdhost_priv *priv = sdhci_f_sdhost_priv(host);
3542
u32 ctrl = 0;
3643

3744
usleep_range(2500, 3000);
@@ -64,7 +71,7 @@ static unsigned int sdhci_f_sdh30_get_min_clock(struct sdhci_host *host)
6471

6572
static void sdhci_f_sdh30_reset(struct sdhci_host *host, u8 mask)
6673
{
67-
struct f_sdhost_priv *priv = sdhci_priv(host);
74+
struct f_sdhost_priv *priv = sdhci_f_sdhost_priv(host);
6875
u32 ctl;
6976

7077
if (sdhci_readw(host, SDHCI_CLOCK_CONTROL) == 0)
@@ -95,49 +102,39 @@ static const struct sdhci_ops sdhci_f_sdh30_ops = {
95102
.set_uhs_signaling = sdhci_set_uhs_signaling,
96103
};
97104

105+
static const struct sdhci_pltfm_data sdhci_f_sdh30_pltfm_data = {
106+
.ops = &sdhci_f_sdh30_ops,
107+
.quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC
108+
| SDHCI_QUIRK_INVERTED_WRITE_PROTECT,
109+
.quirks2 = SDHCI_QUIRK2_SUPPORT_SINGLE
110+
| SDHCI_QUIRK2_TUNING_WORK_AROUND,
111+
};
112+
98113
static int sdhci_f_sdh30_probe(struct platform_device *pdev)
99114
{
100115
struct sdhci_host *host;
101116
struct device *dev = &pdev->dev;
102-
int irq, ctrl = 0, ret = 0;
117+
int ctrl = 0, ret = 0;
103118
struct f_sdhost_priv *priv;
119+
struct sdhci_pltfm_host *pltfm_host;
104120
u32 reg = 0;
105121

106-
irq = platform_get_irq(pdev, 0);
107-
if (irq < 0)
108-
return irq;
109-
110-
host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
122+
host = sdhci_pltfm_init(pdev, &sdhci_f_sdh30_pltfm_data,
123+
sizeof(struct f_sdhost_priv));
111124
if (IS_ERR(host))
112125
return PTR_ERR(host);
113126

114-
priv = sdhci_priv(host);
127+
pltfm_host = sdhci_priv(host);
128+
priv = sdhci_pltfm_priv(pltfm_host);
115129
priv->dev = dev;
116130

117-
host->quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC |
118-
SDHCI_QUIRK_INVERTED_WRITE_PROTECT;
119-
host->quirks2 = SDHCI_QUIRK2_SUPPORT_SINGLE |
120-
SDHCI_QUIRK2_TUNING_WORK_AROUND;
121-
122131
priv->enable_cmd_dat_delay = device_property_read_bool(dev,
123132
"fujitsu,cmd-dat-delay-select");
124133

125134
ret = mmc_of_parse(host->mmc);
126135
if (ret)
127136
goto err;
128137

129-
platform_set_drvdata(pdev, host);
130-
131-
host->hw_name = "f_sdh30";
132-
host->ops = &sdhci_f_sdh30_ops;
133-
host->irq = irq;
134-
135-
host->ioaddr = devm_platform_ioremap_resource(pdev, 0);
136-
if (IS_ERR(host->ioaddr)) {
137-
ret = PTR_ERR(host->ioaddr);
138-
goto err;
139-
}
140-
141138
if (dev_of_node(dev)) {
142139
sdhci_get_of_property(pdev);
143140

@@ -204,24 +201,21 @@ static int sdhci_f_sdh30_probe(struct platform_device *pdev)
204201
err_clk:
205202
clk_disable_unprepare(priv->clk_iface);
206203
err:
207-
sdhci_free_host(host);
204+
sdhci_pltfm_free(pdev);
205+
208206
return ret;
209207
}
210208

211209
static int sdhci_f_sdh30_remove(struct platform_device *pdev)
212210
{
213211
struct sdhci_host *host = platform_get_drvdata(pdev);
214-
struct f_sdhost_priv *priv = sdhci_priv(host);
215-
216-
sdhci_remove_host(host, readl(host->ioaddr + SDHCI_INT_STATUS) ==
217-
0xffffffff);
212+
struct f_sdhost_priv *priv = sdhci_f_sdhost_priv(host);
218213

219214
reset_control_assert(priv->rst);
220215
clk_disable_unprepare(priv->clk);
221216
clk_disable_unprepare(priv->clk_iface);
222217

223-
sdhci_free_host(host);
224-
platform_set_drvdata(pdev, NULL);
218+
sdhci_pltfm_unregister(pdev);
225219

226220
return 0;
227221
}

0 commit comments

Comments
 (0)