Skip to content

Commit 5d6ba60

Browse files
f0rm2l1nmstsirkin
authored andcommitted
vdpa: Add max vqp attr to vdpa_nl_policy for nlattr length check
The vdpa_nl_policy structure is used to validate the nlattr when parsing the incoming nlmsg. It will ensure the attribute being described produces a valid nlattr pointer in info->attrs before entering into each handler in vdpa_nl_ops. That is to say, the missing part in vdpa_nl_policy may lead to illegal nlattr after parsing, which could lead to OOB read just like CVE-2023-3773. This patch adds the missing nla_policy for vdpa max vqp attr to avoid such bugs. Fixes: ad69dd0 ("vdpa: Introduce query of device config layout") Signed-off-by: Lin Ma <linma@zju.edu.cn> Cc: stable@vger.kernel.org Message-Id: <20230727175757.73988-7-dtatulea@nvidia.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
1 parent b3003e1 commit 5d6ba60

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/vdpa/vdpa.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1247,6 +1247,7 @@ static const struct nla_policy vdpa_nl_policy[VDPA_ATTR_MAX + 1] = {
12471247
[VDPA_ATTR_MGMTDEV_DEV_NAME] = { .type = NLA_STRING },
12481248
[VDPA_ATTR_DEV_NAME] = { .type = NLA_STRING },
12491249
[VDPA_ATTR_DEV_NET_CFG_MACADDR] = NLA_POLICY_ETH_ADDR,
1250+
[VDPA_ATTR_DEV_NET_CFG_MAX_VQP] = { .type = NLA_U16 },
12501251
/* virtio spec 1.1 section 5.1.4.1 for valid MTU range */
12511252
[VDPA_ATTR_DEV_NET_CFG_MTU] = NLA_POLICY_MIN(NLA_U16, 68),
12521253
[VDPA_ATTR_DEV_QUEUE_INDEX] = { .type = NLA_U32 },

0 commit comments

Comments
 (0)