Skip to content

Commit 5c054db

Browse files
committed
drm/msm: Be more shouty if per-process pgtables aren't working
Otherwise it is not always obvious if a dt or iommu change is causing us to fall back to global pgtable. Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/537359/ Link: https://lore.kernel.org/r/20230516222039.907690-2-robdclark@gmail.com
1 parent e36ca2f commit 5c054db

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/gpu/drm/msm/msm_iommu.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,12 @@ struct msm_mmu *msm_iommu_pagetable_create(struct msm_mmu *parent)
234234
/* Get the pagetable configuration from the domain */
235235
if (adreno_smmu->cookie)
236236
ttbr1_cfg = adreno_smmu->get_ttbr1_cfg(adreno_smmu->cookie);
237-
if (!ttbr1_cfg)
237+
238+
/*
239+
* If you hit this WARN_ONCE() you are probably missing an entry in
240+
* qcom_smmu_impl_of_match[] in arm-smmu-qcom.c
241+
*/
242+
if (WARN_ONCE(!ttbr1_cfg, "No per-process page tables"))
238243
return ERR_PTR(-ENODEV);
239244

240245
pagetable = kzalloc(sizeof(*pagetable), GFP_KERNEL);

0 commit comments

Comments
 (0)