Skip to content

Commit 5a938ed

Browse files
kishonkwilczynski
authored andcommitted
PCI: keystone: Set mode as Root Complex for "ti,keystone-pcie" compatible
commit 23284ad ("PCI: keystone: Add support for PCIe EP in AM654x Platforms") introduced configuring "enum dw_pcie_device_mode" as part of device data ("struct ks_pcie_of_data"). However it failed to set the mode for "ti,keystone-pcie" compatible. Since the mode defaults to "DW_PCIE_UNKNOWN_TYPE", the following error message is displayed for the v3.65a controller: "INVALID device type 0" Despite the driver probing successfully, the controller may not be functional in the Root Complex mode of operation. So, set the mode as Root Complex for "ti,keystone-pcie" compatible to fix this. Fixes: 23284ad ("PCI: keystone: Add support for PCIe EP in AM654x Platforms") Link: https://lore.kernel.org/r/20240524105714.191642-2-s-vadapalli@ti.com Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> [kwilczynski: commit log, added tag for stable releases] Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Cc: stable@vger.kernel.org
1 parent 9852d85 commit 5a938ed

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/pci/controller/dwc/pci-keystone.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1093,6 +1093,7 @@ static int ks_pcie_am654_set_mode(struct device *dev,
10931093

10941094
static const struct ks_pcie_of_data ks_pcie_rc_of_data = {
10951095
.host_ops = &ks_pcie_host_ops,
1096+
.mode = DW_PCIE_RC_TYPE,
10961097
.version = DW_PCIE_VER_365A,
10971098
};
10981099

0 commit comments

Comments
 (0)