Skip to content

Commit 593bcf6

Browse files
committed
Merge tag 'intel-pinctrl-v6.7-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/intel into devel
intel-pinctrl for v6.7-1 * Merge "Drop runtime PM support for Baytrail and Lynxpoint pinctrl" (Raag) * Small improvements here and there in the Intel pin control drivers (Raag) * Switch to RAII for locking in the Intel core and Cherry View drivers * Enable non-ACPI enumeration in the Intel Denverton driver * Use MODULE_DEVICE_TABLE() instead of MODULE_ALIAS() in a couple of drivers * Introduce array_size.h and use in in the Intel pin control drivers The following is an automated git shortlog grouped by driver: baytrail: - Replace kernel.h by what is actually being used - drop runtime PM support - fix debounce disable case broxton: - Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() cherryview: - reduce scope of PIN_CONFIG_BIAS_HIGH_IMPEDANCE case - Convert to platform remove callback returning void - Simplify code with cleanup helpers - Avoid duplicated I/O - Replace kernel.h by what is actually being used denverton: - Replace MODULE_ALIAS() with MODULE_DEVICE_TABLE() - Enable platform device in the absence of ACPI enumeration intel: - fetch community only when we need it - refine intel_config_set_pull() function - Replace kernel.h by what is actually being used - Simplify code with cleanup helpers lynxpoint: - Replace kernel.h by what is actually being used - drop runtime PM support merrifield: - Replace kernel.h by what is actually being used moorefield: - Replace kernel.h by what is actually being used Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2 parents 30d75d3 + 8d751da commit 593bcf6

18 files changed

+204
-292
lines changed

drivers/pinctrl/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
*/
1313
#define pr_fmt(fmt) "pinctrl core: " fmt
1414

15+
#include <linux/array_size.h>
1516
#include <linux/debugfs.h>
1617
#include <linux/device.h>
1718
#include <linux/err.h>
1819
#include <linux/export.h>
1920
#include <linux/init.h>
20-
#include <linux/kernel.h>
2121
#include <linux/kref.h>
2222
#include <linux/list.h>
2323
#include <linux/seq_file.h>

drivers/pinctrl/intel/pinctrl-baytrail.c

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@
77
*/
88

99
#include <linux/acpi.h>
10+
#include <linux/array_size.h>
1011
#include <linux/bitops.h>
1112
#include <linux/gpio/driver.h>
1213
#include <linux/init.h>
1314
#include <linux/interrupt.h>
1415
#include <linux/io.h>
15-
#include <linux/kernel.h>
1616
#include <linux/module.h>
1717
#include <linux/types.h>
1818
#include <linux/platform_device.h>
19-
#include <linux/pm_runtime.h>
19+
#include <linux/pm.h>
2020
#include <linux/property.h>
2121
#include <linux/seq_file.h>
2222
#include <linux/string_helpers.h>
@@ -722,8 +722,6 @@ static int byt_gpio_request_enable(struct pinctrl_dev *pctl_dev,
722722

723723
raw_spin_unlock_irqrestore(&byt_lock, flags);
724724

725-
pm_runtime_get(vg->dev);
726-
727725
return 0;
728726
}
729727

@@ -734,7 +732,6 @@ static void byt_gpio_disable_free(struct pinctrl_dev *pctl_dev,
734732
struct intel_pinctrl *vg = pinctrl_dev_get_drvdata(pctl_dev);
735733

736734
byt_gpio_clear_triggering(vg, offset);
737-
pm_runtime_put(vg->dev);
738735
}
739736

740737
static void byt_gpio_direct_irq_check(struct intel_pinctrl *vg,
@@ -983,11 +980,18 @@ static int byt_pin_config_set(struct pinctrl_dev *pctl_dev,
983980

984981
break;
985982
case PIN_CONFIG_INPUT_DEBOUNCE:
986-
if (arg)
983+
if (arg) {
987984
conf |= BYT_DEBOUNCE_EN;
988-
else
985+
} else {
989986
conf &= ~BYT_DEBOUNCE_EN;
990987

988+
/*
989+
* No need to update the pulse value.
990+
* Debounce is going to be disabled.
991+
*/
992+
break;
993+
}
994+
991995
switch (arg) {
992996
case 375:
993997
db_pulse = BYT_DEBOUNCE_PULSE_375US;
@@ -1654,7 +1658,6 @@ static int byt_pinctrl_probe(struct platform_device *pdev)
16541658
return ret;
16551659

16561660
platform_set_drvdata(pdev, vg);
1657-
pm_runtime_enable(dev);
16581661

16591662
return 0;
16601663
}
@@ -1743,26 +1746,15 @@ static int byt_gpio_resume(struct device *dev)
17431746
return 0;
17441747
}
17451748

1746-
static int byt_gpio_runtime_suspend(struct device *dev)
1747-
{
1748-
return 0;
1749-
}
1750-
1751-
static int byt_gpio_runtime_resume(struct device *dev)
1752-
{
1753-
return 0;
1754-
}
1755-
17561749
static const struct dev_pm_ops byt_gpio_pm_ops = {
17571750
LATE_SYSTEM_SLEEP_PM_OPS(byt_gpio_suspend, byt_gpio_resume)
1758-
RUNTIME_PM_OPS(byt_gpio_runtime_suspend, byt_gpio_runtime_resume, NULL)
17591751
};
17601752

17611753
static struct platform_driver byt_gpio_driver = {
17621754
.probe = byt_pinctrl_probe,
17631755
.driver = {
17641756
.name = "byt_gpio",
1765-
.pm = pm_ptr(&byt_gpio_pm_ops),
1757+
.pm = pm_sleep_ptr(&byt_gpio_pm_ops),
17661758
.acpi_match_table = byt_gpio_acpi_match,
17671759
.suppress_bind_attrs = true,
17681760
},

drivers/pinctrl/intel/pinctrl-broxton.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -998,6 +998,7 @@ static const struct platform_device_id bxt_pinctrl_platform_ids[] = {
998998
{ "broxton-pinctrl", (kernel_ulong_t)bxt_pinctrl_soc_data },
999999
{ }
10001000
};
1001+
MODULE_DEVICE_TABLE(platform, bxt_pinctrl_platform_ids);
10011002

10021003
static INTEL_PINCTRL_PM_OPS(bxt_pinctrl_pm_ops);
10031004

@@ -1026,6 +1027,4 @@ module_exit(bxt_pinctrl_exit);
10261027
MODULE_AUTHOR("Mika Westerberg <mika.westerberg@linux.intel.com>");
10271028
MODULE_DESCRIPTION("Intel Broxton SoC pinctrl/GPIO driver");
10281029
MODULE_LICENSE("GPL v2");
1029-
MODULE_ALIAS("platform:apollolake-pinctrl");
1030-
MODULE_ALIAS("platform:broxton-pinctrl");
10311030
MODULE_IMPORT_NS(PINCTRL_INTEL);

0 commit comments

Comments
 (0)