bcachefs: Initialize from_inode members for bch_io_opts

roxanan1996 · Kent Overstreet · commit 58517f4df842 · 2025-03-11T11:19:33.000-04:00
When there is no inode source, all "from_inode" members in the structure bhc_io_opts should be set false. Fixes: 7a7c43a ("bcachefs: Add bch_io_opts fields for indicating whether the opts came from the inode") Reported-by: syzbot+c17ad4b4367b72a853cb@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=c17ad4b4367b72a853cb Signed-off-by: Roxana Nicolescu <nicolescu.roxana@protonmail.com> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
diff --git a/fs/bcachefs/inode.c b/fs/bcachefs/inode.c
@@ -1198,6 +1198,7 @@ void bch2_inode_opts_get(struct bch_io_opts *opts, struct bch_fs *c,
 		opts->_name##_from_inode = true;			\
 	} else {							\
 		opts->_name = c->opts._name;				\
+		opts->_name##_from_inode = false;			\
 	}
 	BCH_INODE_OPTS()
 #undef x

Original file line number	Diff line number	Diff line change
`@@ -1198,6 +1198,7 @@ void bch2_inode_opts_get(struct bch_io_opts opts, struct bch_fs c,`
`1198`	`1198`	`opts->_name##_from_inode = true; \`
`1199`	`1199`	`} else { \`
`1200`	`1200`	`opts->_name = c->opts._name; \`
	`1201`	`+ opts->_name##_from_inode = false; \`
`1201`	`1202`	`}`
`1202`	`1203`	`BCH_INODE_OPTS()`
`1203`	`1204`	`#undef x`