Skip to content

Commit 58143c1

Browse files
Wei Yongjunjic23
authored andcommitted
iio: health: afe4403: Fix oob read in afe4403_read_raw
KASAN report out-of-bounds read as follows: BUG: KASAN: global-out-of-bounds in afe4403_read_raw+0x42e/0x4c0 Read of size 4 at addr ffffffffc02ac638 by task cat/279 Call Trace: afe4403_read_raw iio_read_channel_info dev_attr_show The buggy address belongs to the variable: afe4403_channel_leds+0x18/0xffffffffffffe9e0 This issue can be reproduced by singe command: $ cat /sys/bus/spi/devices/spi0.0/iio\:device0/in_intensity6_raw The array size of afe4403_channel_leds is less than channels, so access with chan->address cause OOB read in afe4403_read_raw. Fix it by moving access before use it. Fixes: b36e825 ("iio: health/afe440x: Use regmap fields") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Acked-by: Andrew Davis <afd@ti.com> Link: https://lore.kernel.org/r/20221107151946.89260-1-weiyongjun@huaweicloud.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent 0aa60ff commit 58143c1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/iio/health/afe4403.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,14 +245,14 @@ static int afe4403_read_raw(struct iio_dev *indio_dev,
245245
int *val, int *val2, long mask)
246246
{
247247
struct afe4403_data *afe = iio_priv(indio_dev);
248-
unsigned int reg = afe4403_channel_values[chan->address];
249-
unsigned int field = afe4403_channel_leds[chan->address];
248+
unsigned int reg, field;
250249
int ret;
251250

252251
switch (chan->type) {
253252
case IIO_INTENSITY:
254253
switch (mask) {
255254
case IIO_CHAN_INFO_RAW:
255+
reg = afe4403_channel_values[chan->address];
256256
ret = afe4403_read(afe, reg, val);
257257
if (ret)
258258
return ret;
@@ -262,6 +262,7 @@ static int afe4403_read_raw(struct iio_dev *indio_dev,
262262
case IIO_CURRENT:
263263
switch (mask) {
264264
case IIO_CHAN_INFO_RAW:
265+
field = afe4403_channel_leds[chan->address];
265266
ret = regmap_field_read(afe->fields[field], val);
266267
if (ret)
267268
return ret;

0 commit comments

Comments
 (0)