Skip to content

Commit 57c984f

Browse files
bijudasgregkh
authored andcommitted
tty: serial: sh-sci: Fix sleeping in atomic context
Fix sleeping in atomic context warning as reported by the Smatch static checker tool by replacing disable_irq->disable_irq_nosync. Reported by: Dan Carpenter <dan.carpenter@linaro.org> Fixes: 8749061 ("tty: serial: sh-sci: Add RZ/G2L SCIFA DMA tx support") Cc: stable@kernel.org Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/20230704154818.406913-1-biju.das.jz@bp.renesas.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9b8fef6 commit 57c984f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/tty/serial/sh-sci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ static void sci_start_tx(struct uart_port *port)
590590
dma_submit_error(s->cookie_tx)) {
591591
if (s->cfg->regtype == SCIx_RZ_SCIFA_REGTYPE)
592592
/* Switch irq from SCIF to DMA */
593-
disable_irq(s->irqs[SCIx_TXI_IRQ]);
593+
disable_irq_nosync(s->irqs[SCIx_TXI_IRQ]);
594594

595595
s->cookie_tx = 0;
596596
schedule_work(&s->work_tx);

0 commit comments

Comments
 (0)