Skip to content

Commit 56ad9b2

Browse files
geertuLorenzo Pieralisi
authored andcommitted
PCI: rcar-host: Remove unused static pcie_base and pcie_dev
After the L1 link state transition exception handler rework, the static copies of the remapped PCIe controller address and the PCIe device pointer became unused. Remove them. Link: https://lore.kernel.org/r/f29a8c37bd906dfbe23208cc2b089da17e339a75.1684857051.git.geert+renesas@glider.be Fixes: 6e36203 ("PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
1 parent ac9a786 commit 56ad9b2

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

drivers/pci/controller/pcie-rcar-host.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -41,21 +41,6 @@ struct rcar_msi {
4141
int irq2;
4242
};
4343

44-
#ifdef CONFIG_ARM
45-
/*
46-
* Here we keep a static copy of the remapped PCIe controller address.
47-
* This is only used on aarch32 systems, all of which have one single
48-
* PCIe controller, to provide quick access to the PCIe controller in
49-
* the L1 link state fixup function, called from the ARM fault handler.
50-
*/
51-
static void __iomem *pcie_base;
52-
/*
53-
* Static copy of PCIe device pointer, so we can check whether the
54-
* device is runtime suspended or not.
55-
*/
56-
static struct device *pcie_dev;
57-
#endif
58-
5944
/* Structure representing the PCIe interface */
6045
struct rcar_pcie_host {
6146
struct rcar_pcie pcie;
@@ -879,12 +864,6 @@ static int rcar_pcie_get_resources(struct rcar_pcie_host *host)
879864
}
880865
host->msi.irq2 = i;
881866

882-
#ifdef CONFIG_ARM
883-
/* Cache static copy for L1 link state fixup hook on aarch32 */
884-
pcie_base = pcie->base;
885-
pcie_dev = pcie->dev;
886-
#endif
887-
888867
return 0;
889868

890869
err_irq2:

0 commit comments

Comments
 (0)