Skip to content

Commit 55ea989

Browse files
aneftinanguy11
authored andcommitted
igc: Remove temporary workaround
PHY_CONTROL register works as defined in the IEEE 802.3 specification (IEEE 802.3-2008 22.2.4.1). Tidy up the temporary workaround. User impact: PHY can now be powered down when the ethernet link is down. Testing hints: ip link set down <device> (or just disconnect the ethernet cable). Oldest tested NVM version is: 1045:740. Fixes: 5586838 ("igc: Add code for PHY support") Signed-off-by: Sasha Neftin <sasha.neftin@intel.com> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Tested-by: Naama Meir <naamax.meir@linux.intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent c56d055 commit 55ea989

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/net/ethernet/intel/igc/igc_phy.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,7 @@ void igc_power_down_phy_copper(struct igc_hw *hw)
130130
/* The PHY will retain its settings across a power down/up cycle */
131131
hw->phy.ops.read_reg(hw, PHY_CONTROL, &mii_reg);
132132
mii_reg |= MII_CR_POWER_DOWN;
133-
134-
/* Temporary workaround - should be removed when PHY will implement
135-
* IEEE registers as properly
136-
*/
137-
/* hw->phy.ops.write_reg(hw, PHY_CONTROL, mii_reg);*/
133+
hw->phy.ops.write_reg(hw, PHY_CONTROL, mii_reg);
138134
usleep_range(1000, 2000);
139135
}
140136

0 commit comments

Comments
 (0)