Skip to content

Commit 55b6a69

Browse files
isilenceaxboe
authored andcommitted
io_uring: fix acquire/release annotations
We do conditional locking, so __io_cq_lock() and friends not always actually grab/release the lock, so kill misleading annotations. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Link: https://lore.kernel.org/r/2a098f9144c24cab622f8bf90b39f44da5d0401e.1687518903.git.asml.silence@gmail.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent f432b76 commit 55b6a69

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

io_uring/io_uring.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,6 @@ void __io_commit_cqring_flush(struct io_ring_ctx *ctx)
626626
}
627627

628628
static inline void __io_cq_lock(struct io_ring_ctx *ctx)
629-
__acquires(ctx->completion_lock)
630629
{
631630
if (!ctx->task_complete)
632631
spin_lock(&ctx->completion_lock);
@@ -646,7 +645,6 @@ static inline void io_cq_lock(struct io_ring_ctx *ctx)
646645

647646
/* keep it inlined for io_submit_flush_completions() */
648647
static inline void __io_cq_unlock_post(struct io_ring_ctx *ctx)
649-
__releases(ctx->completion_lock)
650648
{
651649
io_commit_cqring(ctx);
652650
__io_cq_unlock(ctx);
@@ -655,7 +653,6 @@ static inline void __io_cq_unlock_post(struct io_ring_ctx *ctx)
655653
}
656654

657655
static void __io_cq_unlock_post_flush(struct io_ring_ctx *ctx)
658-
__releases(ctx->completion_lock)
659656
{
660657
io_commit_cqring(ctx);
661658

0 commit comments

Comments
 (0)