Skip to content

Commit 551539a

Browse files
jwrdegoedebroonie
authored andcommitted
ASoC: rt5645: Make LattePanda board DMI match more precise
The DMI strings used for the LattePanda board DMI quirks are very generic. Using the dmidecode database from https://linux-hardware.org/ shows that the chosen DMI strings also match the following 2 laptops which also have a rt5645 codec: Insignia NS-P11W7100 https://linux-hardware.org/?computer=E092FFF8BA04 Insignia NS-P10W8100 https://linux-hardware.org/?computer=AFB6C0BF7934 All 4 hw revisions of the LattePanda board have "S70CR" in their BIOS version DMI strings: DF-BI-7-S70CR100-* DF-BI-7-S70CR110-* DF-BI-7-S70CR200-* LP-BS-7-S70CR700-* See e.g. https://linux-hardware.org/?computer=D98250A817C0 Add a partial (non exact) DMI match on this string to make the LattePanda board DMI match more precise to avoid false-positive matches. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://msgid.link/r/20240211212736.179605-1-hdegoede@redhat.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 8c41be2 commit 551539a

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

sound/soc/codecs/rt5645.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3838,6 +3838,16 @@ static const struct dmi_system_id dmi_platform_data[] = {
38383838
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
38393839
DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
38403840
DMI_EXACT_MATCH(DMI_BOARD_VERSION, "Default string"),
3841+
/*
3842+
* Above strings are too generic, LattePanda BIOS versions for
3843+
* all 4 hw revisions are:
3844+
* DF-BI-7-S70CR100-*
3845+
* DF-BI-7-S70CR110-*
3846+
* DF-BI-7-S70CR200-*
3847+
* LP-BS-7-S70CR700-*
3848+
* Do a partial match for S70CR to avoid false positive matches.
3849+
*/
3850+
DMI_MATCH(DMI_BIOS_VERSION, "S70CR"),
38413851
},
38423852
.driver_data = (void *)&lattepanda_board_platform_data,
38433853
},

0 commit comments

Comments
 (0)