Skip to content

Commit 53d862f

Browse files
danglin44hdeller
authored andcommitted
parisc: Fix invalidate/flush vmap routines
Cache move-in for virtual accesses is controlled by the TLB. Thus, we must generally purge TLB entries before flushing. The flush routines must use TLB entries that inhibit cache move-in. V2: Load physical address prior to flushing TLB. In flush_cache_page, flush TLB when flushing and purging. V3: Don't flush when start equals end. Signed-off-by: John David Anglin <dave.anglin@bell.net> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 411fadd commit 53d862f

File tree

1 file changed

+19
-5
lines changed

1 file changed

+19
-5
lines changed

arch/parisc/kernel/cache.c

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -611,8 +611,8 @@ void
611611
flush_cache_page(struct vm_area_struct *vma, unsigned long vmaddr, unsigned long pfn)
612612
{
613613
if (pfn_valid(pfn)) {
614+
flush_tlb_page(vma, vmaddr);
614615
if (likely(vma->vm_mm->context.space_id)) {
615-
flush_tlb_page(vma, vmaddr);
616616
__flush_cache_page(vma, vmaddr, PFN_PHYS(pfn));
617617
} else {
618618
__purge_cache_page(vma, vmaddr, PFN_PHYS(pfn));
@@ -624,6 +624,7 @@ void flush_kernel_vmap_range(void *vaddr, int size)
624624
{
625625
unsigned long start = (unsigned long)vaddr;
626626
unsigned long end = start + size;
627+
unsigned long flags, physaddr;
627628

628629
if ((!IS_ENABLED(CONFIG_SMP) || !arch_irqs_disabled()) &&
629630
(unsigned long)size >= parisc_cache_flush_threshold) {
@@ -632,15 +633,22 @@ void flush_kernel_vmap_range(void *vaddr, int size)
632633
return;
633634
}
634635

635-
flush_kernel_dcache_range_asm(start, end);
636-
flush_tlb_kernel_range(start, end);
636+
while (start < end) {
637+
physaddr = lpa(start);
638+
purge_tlb_start(flags);
639+
pdtlb(SR_KERNEL, start);
640+
purge_tlb_end(flags);
641+
flush_dcache_page_asm(physaddr, start);
642+
start += PAGE_SIZE;
643+
}
637644
}
638645
EXPORT_SYMBOL(flush_kernel_vmap_range);
639646

640647
void invalidate_kernel_vmap_range(void *vaddr, int size)
641648
{
642649
unsigned long start = (unsigned long)vaddr;
643650
unsigned long end = start + size;
651+
unsigned long flags, physaddr;
644652

645653
if ((!IS_ENABLED(CONFIG_SMP) || !arch_irqs_disabled()) &&
646654
(unsigned long)size >= parisc_cache_flush_threshold) {
@@ -649,7 +657,13 @@ void invalidate_kernel_vmap_range(void *vaddr, int size)
649657
return;
650658
}
651659

652-
purge_kernel_dcache_range_asm(start, end);
653-
flush_tlb_kernel_range(start, end);
660+
while (start < end) {
661+
physaddr = lpa(start);
662+
purge_tlb_start(flags);
663+
pdtlb(SR_KERNEL, start);
664+
purge_tlb_end(flags);
665+
purge_dcache_page_asm(physaddr, start);
666+
start += PAGE_SIZE;
667+
}
654668
}
655669
EXPORT_SYMBOL(invalidate_kernel_vmap_range);

0 commit comments

Comments
 (0)