Skip to content

Commit 5326ab7

Browse files
Maximilian Immanuel Brandtnermstsirkin
authored andcommitted
virtio_console: fix order of fields cols and rows
According to section 5.3.6.2 (Multiport Device Operation) of the virtio spec(version 1.2) a control buffer with the event VIRTIO_CONSOLE_RESIZE is followed by a virtio_console_resize struct containing cols then rows. The kernel implements this the wrong way around (rows then cols) resulting in the two values being swapped. Signed-off-by: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com> Message-Id: <20250324144300.905535-1-maxbr@linux.ibm.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
1 parent fbd3039 commit 5326ab7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/char/virtio_console.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1576,8 +1576,8 @@ static void handle_control_message(struct virtio_device *vdev,
15761576
break;
15771577
case VIRTIO_CONSOLE_RESIZE: {
15781578
struct {
1579-
__virtio16 rows;
15801579
__virtio16 cols;
1580+
__virtio16 rows;
15811581
} size;
15821582

15831583
if (!is_console_port(port))

0 commit comments

Comments
 (0)