Skip to content

Commit 52defa4

Browse files
sohilmehKAGA-KOKO
authored andcommitted
x86/smpboot: Remove a stray comment about CPU hotplug
This old comment is irrelavant to the logic of disabling interrupts and could be misleading. Remove it. Now, hlt_play_dead() resembles the code that the comment was initially added for, but, it doesn't make sense anymore because an offlined cpu could also be put into other states such as mwait. Signed-off-by: Sohil Mehta <sohil.mehta@intel.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/20230727180533.3119660-2-sohil.mehta@intel.com
1 parent 6eaae19 commit 52defa4

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

arch/x86/kernel/smpboot.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1614,9 +1614,7 @@ void play_dead_common(void)
16141614
idle_task_exit();
16151615

16161616
cpuhp_ap_report_dead();
1617-
/*
1618-
* With physical CPU hotplug, we should halt the cpu
1619-
*/
1617+
16201618
local_irq_disable();
16211619
}
16221620

0 commit comments

Comments
 (0)