Skip to content

Commit 525b108

Browse files
LGA1150davem330
authored andcommitted
net: phy: mediatek: remove PHY mode check on MT7531
The function mt7531_phy_mode_supported in the DSA driver set supported mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL for the internal PHY, so this check breaks the PHY initialization: mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL Remove the check to make it work again. Reported-by: Hauke Mehrtens <hauke@hauke-m.de> Fixes: e40d2cc ("net: phy: add MediaTek Gigabit Ethernet PHY driver") Signed-off-by: DENG Qingfang <dqfext@gmail.com> Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> Tested-by: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 032062f commit 525b108

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/net/phy/mediatek-ge.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
5555

5656
static int mt7531_phy_config_init(struct phy_device *phydev)
5757
{
58-
if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
59-
return -EINVAL;
60-
6158
mtk_gephy_config_init(phydev);
6259

6360
/* PHY link down power saving enable */

0 commit comments

Comments
 (0)