f2fs: fix error path of f2fs_submit_page_read()

chaseyu · Jaegeuk Kim · commit 5118697f7215 · 2023-08-23T10:24:40.000-07:00
In error path of f2fs_submit_page_read(), it missed to call
iostat_update_and_unbind_ctx() and free bio_post_read_ctx, fix it.

Signed-off-by: Chao Yu &lt;chao@kernel.org&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
@@ -1167,6 +1167,9 @@ static int f2fs_submit_page_read(struct inode *inode, struct page *page,
 	f2fs_wait_on_block_writeback(inode, blkaddr);
 
 	if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) {
+		iostat_update_and_unbind_ctx(bio);
+		if (bio->bi_private)
+			mempool_free(bio->bi_private, bio_post_read_ctx_pool);
 		bio_put(bio);
 		return -EFAULT;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1167,6 +1167,9 @@ static int f2fs_submit_page_read(struct inode inode, struct page page,`
`1167`	`1167`	`f2fs_wait_on_block_writeback(inode, blkaddr);`
`1168`	`1168`
`1169`	`1169`	`if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) {`
	`1170`	`+ iostat_update_and_unbind_ctx(bio);`
	`1171`	`+ if (bio->bi_private)`
	`1172`	`+ mempool_free(bio->bi_private, bio_post_read_ctx_pool);`
`1170`	`1173`	`bio_put(bio);`
`1171`	`1174`	`return -EFAULT;`
`1172`	`1175`	`}`