Skip to content

Commit 4dd8752

Browse files
jhovoldrafaeljw
authored andcommitted
serial: qcom-geni: drop bogus runtime pm state update
The runtime PM state should not be changed by drivers that do not implement runtime PM even if it happens to work around a bug in PM core. With the wake irq arming now fixed, drop the bogus runtime PM state update which left the device in active state (and could potentially prevent a parent device from suspending). Fixes: f397441 ("tty: serial: qcom_geni_serial: Wakeup IRQ cleanup") Cc: 5.6+ <stable@vger.kernel.org> # 5.6+ Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent e7b9152 commit 4dd8752

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/tty/serial/qcom_geni_serial.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1681,13 +1681,6 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
16811681
if (ret)
16821682
return ret;
16831683

1684-
/*
1685-
* Set pm_runtime status as ACTIVE so that wakeup_irq gets
1686-
* enabled/disabled from dev_pm_arm_wake_irq during system
1687-
* suspend/resume respectively.
1688-
*/
1689-
pm_runtime_set_active(&pdev->dev);
1690-
16911684
if (port->wakeup_irq > 0) {
16921685
device_init_wakeup(&pdev->dev, true);
16931686
ret = dev_pm_set_dedicated_wake_irq(&pdev->dev,

0 commit comments

Comments
 (0)